[oe] [PATCH 2/3] perl: use only one method all_perl_packages

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Wed Aug 4 13:51:57 UTC 2010


.. to avoid
ERROR: Error Method already seen: all_perl_packages in' perl_5.8.8.bb'
now in 'perl_5.10.1.bb'

TODO: error() already prints "ERROR:" so the "Error" in above msg is
redundant

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 recipes/perl/perl_5.10.1.bb  |    7 +------
 recipes/perl/perl_5.8.8.bb   |    7 +------
 recipes/perl/perl_helper.inc |    8 ++++++++
 3 files changed, 10 insertions(+), 12 deletions(-)
 create mode 100644 recipes/perl/perl_helper.inc

diff --git a/recipes/perl/perl_5.10.1.bb b/recipes/perl/perl_5.10.1.bb
index 75993b5..dd0bb0f 100644
--- a/recipes/perl/perl_5.10.1.bb
+++ b/recipes/perl/perl_5.10.1.bb
@@ -210,12 +210,7 @@ FILES_${PN}-doc = "${datadir}/perl/${PV}/*/*.txt \
 
 RPROVIDES_perl-lib = "perl-lib"
 
-def all_perl_packages(d):
-    depchains = (d.getVar("DEPCHAIN_POST", True) or "").split()
-    blacklist = ["perl-modules", "perl-misc", "perl-pod", "perl-doc"]
-    for pkg in d.getVar("PACKAGES", True).split():
-        if not pkg in blacklist and not any(pkg.endswith(post) for post in depchains):
-            yield pkg
+require perl_helper.inc
 
 # Create a perl-modules package recommending all the other perl
 # packages (actually the non modules packages and not created too)
diff --git a/recipes/perl/perl_5.8.8.bb b/recipes/perl/perl_5.8.8.bb
index 5400e69..d546a15 100644
--- a/recipes/perl/perl_5.8.8.bb
+++ b/recipes/perl/perl_5.8.8.bb
@@ -212,12 +212,7 @@ FILES_${PN}-doc = "${datadir}/perl/${PV}/*/*.txt \
 
 RPROVIDES_perl-lib = "perl-lib"
 
-def all_perl_packages(d):
-    depchains = (d.getVar("DEPCHAIN_POST", True) or "").split()
-    blacklist = ["perl-modules", "perl-misc", "perl-pod", "perl-doc"]
-    for pkg in d.getVar("PACKAGES", True).split():
-        if not pkg in blacklist and not any(pkg.endswith(post) for post in depchains):
-            yield pkg
+require perl_helper.inc
 
 # Create a perl-modules package recommending all the other perl
 # packages (actually the non modules packages and not created too)
diff --git a/recipes/perl/perl_helper.inc b/recipes/perl/perl_helper.inc
new file mode 100644
index 0000000..ddde0b8
--- /dev/null
+++ b/recipes/perl/perl_helper.inc
@@ -0,0 +1,8 @@
+# helper functions for perl
+def all_perl_packages(d):
+    depchains = (d.getVar("DEPCHAIN_POST", True) or "").split()
+    blacklist = ["perl-modules", "perl-misc", "perl-pod", "perl-doc"]
+    for pkg in d.getVar("PACKAGES", True).split():
+        if not pkg in blacklist and not any(pkg.endswith(post) for post in depchains):
+            yield pkg
+
-- 
1.7.1





More information about the Openembedded-devel mailing list