[oe] [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros

[Paul Menzel]

Is there an upstream bug for this? If not, it would be great if you
could sent it upstream.

Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:
> Signed-off-by: Henri Bragge <henri.bragge at dcombus.com>
> ---
>  recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   24 ++++++++++++++++++++++++
>  recipes/gsnmp/gsnmp_0.3.0.bb              |    3 ++-
>  2 files changed, 26 insertions(+), 1 deletions(-)
>  create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> 
> diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> new file mode 100644
> index 0000000..138c9e6
> --- /dev/null
> +++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> @@ -0,0 +1,24 @@
> +diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
> +--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
> ++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
> +@@ -6,7 +6,7 @@
> + dnl usually in <utime.h>.
> + dnl Some systems have utime.h but don't declare the struct anywhere.
> + 
> +-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
> ++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
> + [
> +   AC_CHECK_HEADERS(utime.h)
> +   AC_REQUIRE([AC_HEADER_TIME])
> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
> +--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
> ++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
> +@@ -1,7 +1,7 @@
> + dnl AM_PATH_GSNMP()
> + dnl 
> + 
> +-AC_DEFUN(AM_PATH_GSNMP,
> ++AC_DEFUN([AM_PATH_GSNMP],
> + [
> +   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
> + ])

Why is this check needed? Maybe add a note to the commit message or
split the patch.

> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
> index b191762..6287010 100644
> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
>  DEPENDS = "glib-2.0 gnet"
>  PR = "r0"

I guess you need to increase `PR`.

[…]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100809/68068198/attachment-0002.sig>