[oe] [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros

[Paul Menzel]

Am Montag, den 09.08.2010, 15:05 +0300 schrieb Henri Bragge:
> Paul Menzel wrote:
> > Is there an upstream bug for this? If not, it would be great if you
> > could sent it upstream.
> 
> The bug is still present in upstream too, but I will send this patch to 
> the gsnmp maintainer if it does the trick (or should it be the other way 
> around?).

I have no idea [1]. But I guess it would not hurt if you send it
upstream anyway.

[1] http://wiki.openembedded.net/index.php/Push_patches_upstream

> > Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:

[…]

> >> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
> >> +--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
> >> ++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
> >> +@@ -1,7 +1,7 @@
> >> + dnl AM_PATH_GSNMP()
> >> + dnl 
> >> + 
> >> +-AC_DEFUN(AM_PATH_GSNMP,
> >> ++AC_DEFUN([AM_PATH_GSNMP],
> >> + [
> >> +   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
> >> + ])
> >
> > Why is this check needed? Maybe add a note to the commit message or
> > split the patch.
> 
> About that I've no idea, notice that I just added the brackets there.

Sorry, the double patch got me confused.

> >> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
> >> index b191762..6287010 100644
> >> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
> >> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
> >> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
> >>  DEPENDS = "glib-2.0 gnet"
> >>  PR = "r0"
> >>     
> >
> > I guess you need to increase `PR`.
> >
> > […]
> 
> Will do.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100809/e6fe708e/attachment-0002.sig>