[oe] [PATCH] bison: add flex dependency

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Tue Aug 17 07:00:23 UTC 2010


2010/8/16 Jason Kridner <jkridner at beagleboard.org>:
> It seems that bison was missing this dependency.  I'm not 100% certain this
> is the right way to add it, so I'm leaving off my signed-off-by in hopes that
> someone will ack this who really knows.
>
> ---
>  recipes/bison/bison.inc |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/bison/bison.inc b/recipes/bison/bison.inc
> index 22672e2..d32f454 100644
> --- a/recipes/bison/bison.inc
> +++ b/recipes/bison/bison.inc
> @@ -3,12 +3,12 @@ HOMEPAGE = "http://www.gnu.org/software/bison/"
>  LICENSE = "GPL"
>  SECTION = "devel"
>  PRIORITY = "optional"
> -DEPENDS = "virtual/libintl"
> +DEPENDS = "virtual/libintl virtual/flex"
>
>  SRC_URI = "${GNU_MIRROR}/bison/bison-${PV}.tar.gz \
>           file://m4.patch"
>
> -INC_PR = "r7"
> +INC_PR = "r8"
>
>  inherit autotools gettext
>
> --

It is my impression that virtual is only to be used if there can be
different packages acting as source (so different providers) (e.g. for
gcc, libc, u-boot, kernel etc)
AFAIK that is not the case for flex so I would just have written
DEPENDS = "virtual/libintl flex-native"

Anyway, I peeked in the code and I can confirm that a dependency on
flex exists. This went unnoticed until now as normally flex was
already dragged in by another package.
Either the change from Jason or the line I give above can have my ack.

Frans




More information about the Openembedded-devel mailing list