[oe] [PATCH] quilt: disable packaged staging on native builds

[Chris Larson]

On Tue, Aug 17, 2010 at 1:03 PM, Frans Meulenbroeks <
fransmeulenbroeks at gmail.com> wrote:

> 2010/8/17 Jason Kridner <jkridner at beagleboard.org>:
> >
> > Signed-off-by: Jason Kridner <jkridner at beagleboard.org>
> > ---
> >  recipes/quilt/quilt-native.inc |    3 +++
> >  recipes/quilt/quilt_0.48.bb    |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/recipes/quilt/quilt-native.inc
> b/recipes/quilt/quilt-native.inc
> > index 10d8183..f422b63 100644
> > --- a/recipes/quilt/quilt-native.inc
> > +++ b/recipes/quilt/quilt-native.inc
> > @@ -6,6 +6,9 @@ RDEPENDS_${PN} = "diffstat-native patch-native
> bzip2-native util-linux-native"
> >  FILESPATHPKG =. quilt-${PV}
> >  INHIBIT_AUTOTOOLS_DEPS = "1"
> >
> > +# Several packages fail to patch when using quilt from packaged staging
> > +PSTAGING_DISABLED_virtclass-native = "1"
> > +
> >  inherit autotools native
> >
> >  PATCHTOOL = "patch"
> > diff --git a/recipes/quilt/quilt_0.48.bb b/recipes/quilt/quilt_0.48.bb
> > index 0a066df..99dc2a2 100644
> > --- a/recipes/quilt/quilt_0.48.bb
> > +++ b/recipes/quilt/quilt_0.48.bb
> > @@ -1,6 +1,6 @@
> >  require quilt-package.inc
> >
> > -PR="r1"
> > +PR="r2"
> >
> >  SRC_URI[md5sum] = "f77adda60039ffa753f3c584a286f12b"
> >  SRC_URI[sha256sum] =
> "73fd760d3b5cbf06417576591dc37d67380d189392db9000c21b7cbebee49ffc"
> > --
> > 1.5.6.4
>
> I have some concerns with this patch.
> I have a quilt native in my pstage dir from aug 7. (pstage is outside
> TMPDIR)
> Just did a bitbake beagleboard-demo-image after removing TMPDIR, with
> quilt-native and quite some other packages in my pstage dir.
> I am at "Running task 7313 of 11636", lots of packages have been
> compiled and no patch has failed.
>
> My proposal is to put this patch on hold until proven to be an issue
> by someone else.


Did you build with TMPDIR in a *different* location using prebuilts?  If not
you didn't prove anything at all about the relocatability of quilt.  If a
package isn't relocatable, it shouldn't be enabled for pstaging, as the
package can't be used reliably.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics