[oe] [PATCH 1/3] Add falconwing machine config

[Graham Gower]

On 19 August 2010 09:33, Sean Cross <sean at chumby.com> wrote:
>
> On Aug 18, 2010, at 4:15 PM, Graham Gower wrote:
>
>> On 19 August 2010 08:33, Sean Cross <sean at chumby.com> wrote:
>>>
>>> Signed-off-by: Sean Cross <sean at chumby.com>
>>> ---
>>>  conf/machine/chumby-falconwing.conf |   24 ++++++++++++++++++++++++
>>>  1 files changed, 24 insertions(+), 0 deletions(-)
>>>  create mode 100644 conf/machine/chumby-falconwing.conf
>>> diff --git a/conf/machine/chumby-falconwing.conf b/conf/machine/chumby-falconwin
>>> g.conf
>>> new file mode 100644
>>> index 0000000..ed48cdb
>>> --- /dev/null
>>> +++ b/conf/machine/chumby-falconwing.conf
>>> @@ -0,0 +1,24 @@
>>> +#@TYPE: Machine
>>> +#@Name: chumby Falconwing machine config.+#@DESCRIPTION: Machine configuration for chumby Falconwing-based boards, such a
>>
>> You seem to have a missing newline in this part of the patch...
>
> You're correct.  Terminal.app sometimes eats newlines when doing copy+paste, and I missed that.  Here's the machine config again.
>
> The description is longer than 80 characters.  I see several machines that also have descriptions longer than 80 characters.  Is that acceptable?  If not, what is the preferred mechanism of breaking up data such as that?
>

Ordinarily, I'd say use a backslash. But that would depend on what is
parsing the #@DESCRIPTION field (is this parsed by some documentation
generating script somewhere?). The only example of using a backslash
is in xilinx-ml410.conf.

-Graham