[oe] [PATCH] added a .bb for node.js

[Frans Meulenbroeks]

Can't judge the patches, but will give some feedback on one of your
recipe versions

2010/8/19 AJ ONeal <coolaj86 at gmail.com>:

> diff --git a/recipes/node/node_0.1.104.bb b/recipes/node/node_0.1.104.bb
> new file mode 100644
> index 0000000..a99eaff
> --- /dev/null
> +++ b/recipes/node/node_0.1.104.bb
> @@ -0,0 +1,28 @@
> +DESCRIPTION = "nodeJS Evented I/O for V8 JavaScript"

can you add std headers like HOMEPAGE and LICENSE
see other recipes for examples

> +PR = "r0"
> +DEPENDS = "openssl"
> +SRC_URI = " \
> +http://nodejs.org/dist/node-v${PV}.tar.gz \
> +file://libev-arm-cross.patch;apply=yes \
> +file://node-arm-cross.patch;apply=yes \
please indent (with spaces); apply=yes is default for patch files so
no need to add it
> +"
> +SRC_URI[md5sum] = "907fa1e0a2f1f0c3df5efc97fd05a7d2"
> +SRC_URI[sha256sum] = "a1c776f44bc07305dc0e56df17cc3260eaafa0394c3b06c27448ad85bec272df"
> +S = "${WORKDIR}/node-v${PV}"
> +do_configure () {
> +export DEST_CPU=arm
> +./configure
> +# skip complaints about 'config.log'
> +cat /dev/null > ${S}/build/config.log
> +}
> +do_qa_configure () {
> +}
needed?

> +do_compile () {
> +export DEST_CPU=arm
> +make
if it works use: oe_runmake DEST_CPU=arm
> +}
> +do_install () {
> +install -d ${D}${bindir}/
> +install -m 0755 ${S}/node ${D}${bindir}/
is there no make install? If so you probably should do
oe_runmake install
maybe overriding DESTDIR or whatever your makefile uses

> +}
> +FILES_${PN} = "${bindir}/node"

I think your bindir will be in the package anyway (and shouldn't it be
${D}${bindir}; don't do this often enough to know for sure, peek into
other recipes)

Please resubmit as v2

Frans