[oe] PACKAGE_ARCH_pn-${PN} should work?

[Khem Raj]

On Mon, Aug 9, 2010 at 11:51 AM, Khem Raj <raj.khem at gmail.com> wrote:
> On Mon, Aug 9, 2010 at 7:36 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
>> or did it worked before?
>>
>> Today I noticed it keeps PACKAGE_ARCH = "all" in task-x11-server
>> http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=bf3cf7b95cb10c830c39ca4bfec4e7fcc19dad83
>>
>> It's used in few more places (mostly OM/SHR which can be my fault from merging shr/import):
>>
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-usb-gadget-mode_om-gta01 = "armv4t"
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-usb-gadget-mode_om-gta02 = "armv4t"
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-keymaps_om-gta01 = "armv4t"
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-keymaps_om-gta02 = "armv4t"
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-neod_om-gta01 = "armv4t"
>> conf/distro/openmoko.conf:PACKAGE_ARCH_pn-neod_om-gta02 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-usb-gadget-mode_om-gta01 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-usb-gadget-mode_om-gta02 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-keymaps_om-gta01 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-keymaps_om-gta02 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-neod_om-gta01 = "armv4t"
>> conf/distro/shr.conf:PACKAGE_ARCH_pn-neod_om-gta02 = "armv4t"
>> recipes/fbreader/fbreader_0.8.2a.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/freesmartphone/frameworkd_git.bb:PACKAGE_ARCH_pn-${PN}-config = "${MACHINE_ARCH}"
>> recipes/miniinit/miniinit.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/mipl-mipv6/mipv6_1.1-v2.4.26.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/mipl-mipv6/mipv6_2.0.2.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/obsolete/shr/alsa-scenarii-shr_git.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/openmoko2/openmoko-alsa-scenarios_svn.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/shadow/shadow.inc:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/shr/frameworkd-config-shr_git.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>> recipes/sysvinit/sysvinit_2.86.bb:PACKAGE_ARCH_pn-${PN}-inittab = "${MACHINE_ARCH}"
>> recipes/usb-gadget-mode/usb-gadget-mode.bb:PACKAGE_ARCH_pn-${PN} = "${MACHINE_ARCH}"
>>
>> Regards,
>>
>
> this is from my commit
>
> commit 4e9905b2be6438156dc8ad88839de04e91c922ec
> Author: Khem Raj <raj.khem at gmail.com>
> Date:   Mon Jul 26 15:09:10 2010 -0700
>
>    recipes: Replace ${PN} override with pn-${PN} for PACKAGE_ARCH
>
>    * Needed to get CURRENT_TARGET_SYS to evaluate correctly in bitbake.conf
>
>    Signed-off-by: Khem Raj <raj.khem at gmail.com>
>
>
>
> hmm it worked well and the problem was other way around what
> you are seeing but now I dont remember which package it was.
> but if I check with the recipe you mentioned then I see
> that override did not work.
> We can revert it if needed but I would like to understand
> why pn-${PN} did not work

It works in few case where PN is only candidate to be overridden
but not when something like ${PN}-foo is needed so it works in some
cases but not in all. I have therefore reverted it.

Thanks for reporting.

>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>