[oe] [RFC] review process

Dr. Michael Lauer mickey at vanille-media.de
Fri Aug 27 12:37:59 UTC 2010


Am Freitag, den 27.08.2010, 14:15 +0200 schrieb Frans Meulenbroeks:
> 1. If a patch does not get any review feedback in X weeks time; it is
> ok to apply it. People who need more time to review a patch can
> mention that in a short reply. In that case they are granted Y more
> weeks to review.
> (suggestion: X = Y = 2)
> 2. If someone NAKs a patch it is obligatory to provide an explanation
> why the patch is not good.
> Rationale is that
> a) people can fix the problem seen by the reviewer
> b) people learn from it
> c) if there is a disagreement it can be discussed (and if needed
> raised to the TSC)
> 3) NAKs that are not motivated/explained can be ignored as not given.
> 
> Your feedback, suggestions, additions, amendments, whatever is appreciated.

I agree with that. If someone does the work to create a patch he thinks
is worthwhile to apply the least we can do when NAKing is to explain why
it is not a good idea.

:M:






More information about the Openembedded-devel mailing list