[oe] [PATCH 2/2] recipes: Update recipes to get 'bitbake world' parse and calculate runqueue successfully.

[Khem Raj]

Hi Koen

Thanks for your time to look into it and comments. It would help if
you could explain a bit more why you think
changes are not good. I have individually explained the reasons below
your comments. It would really help to
improve these if you could shed some light on the reason why you think
the changes are not good. If you think


On Fri, Aug 27, 2010 at 4:08 AM, Koen Kooi <k.kooi at student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 27-08-10 10:11, Khem Raj wrote:
>> * Move recipes to nonwotking which are depending upon other recipes
>>   which are already in nonworking state.
>>
>> * Fix other recipes for renamed dependencies etc.
>>
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>>  recipes/angstrom/angstrom-bootmanager.bb           |    2 +-
>
> NAK


if you have explained whats wrong that would have helped. I certainly dont
claim to be knowing all the recipes. recipes it depends upon do not exist
so whats the best thing to do ? This same applies to your other NAKs too.

>
>>  recipes/esc/esc-node-demo_git.bb                   |    4 +-
>
> NAK

This depends on a recipe which is under review and I have commented the same.
Or do you see something else is wrong?

>
>>  recipes/meta/meta-toolchain-arago-dvsdk.bb         |    1 +
>
> NAK

I wonder if you really looked at this change because all it does is removes
meta-toolchain-arago-dvsdk from world build. What problem do you see here ?

>
>>  recipes/sugar/sugar-fructose.bb                    |    2 +-
>
> NAK

Elena already explained it.

>
>>  recipes/tasks/task-arago-toolchain-target.bb       |    3 +-
>
> NAK

This change is removing libpng12-dev which is not provides. and
e2fsprogs-libs-dev
is now e2fsprogs-dev or am I missing some point here.

>
>>  recipes/tasks/task-demo-x11.bb                     |   17 ++---
>
> NAK

are libgles-omap3-x11demos different that non existing libgles-omap3-demos
if so then I can change it to just removing libgles-omap3-demos

>
>>  recipes/tasks/task-gmae.bb                         |    7 ++
>
> NAK

it uses XSERVER what doesnt really define it. What is wrong here.

>
>>  recipes/tasks/task-gpe.bb                          |    6 +-
>
> NAK

virtual/xserver is a virtual target you can not RDEPEND on it
but you can depend atleast thats what bitbake tells me.

>
>>  recipes/udev/udev-compat141_141.bb                 |    6 ++-
>
> NAK

if machine is not one of spitz akita c70x poodle then it is not needed
to RDEPEND on it. what is wrong here

>
>>  recipes/vlc/vlc-davinci_0.8.6h.bb                  |    2 +-
>
> NAK

is non existing codec-engine different then ti-codec-engine ?
if yes then I guess either these codecs should be committed to OE
or the recipe should be moved into nonworking what would you think.





> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFMd5y9MkyGM64RGpERAp7CAJ9Hdw0XIynob+zbnWWDSvB2LMCR7QCggZUJ
> c4ydMxejzuOOqvU2RJYBWxA=
> =RBfq
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>