[oe] [PATCH] wxwidgets: added libxinerama to DEPENDS

Matthew Thompson matthewbot at gmail.com
Sun Dec 5 20:12:40 UTC 2010


On Sun, 2010-12-05 at 17:13 +0100, Eric Bénard wrote:
> Hi,
> 
> On 05/12/2010 17:02, Matt Thompson wrote:
> > Signed-off-by: Matt Thompson<matthewbot at gmail.com>
> > ---
> >   recipes/wxwidgets/wxwidgets.inc |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/recipes/wxwidgets/wxwidgets.inc b/recipes/wxwidgets/wxwidgets.inc
> > index 2fb2bef..4c4f77f 100644
> > --- a/recipes/wxwidgets/wxwidgets.inc
> > +++ b/recipes/wxwidgets/wxwidgets.inc
> > @@ -2,7 +2,7 @@ DESCRIPTION = "wxWidgets is a cross platform application framework utilizing nat
> >   HOMEPAGE = "http://www.wxwidgets.org"
> >   SECTION = "x11/libs"
> >   LICENSE = "wxWindows"
> > -DEPENDS = "gtk+ jpeg tiff libpng zlib expat"
> > +DEPENDS = "gtk+ jpeg tiff libpng zlib expat libxinerama"
> >
> maybe this is obvious for wxwidgets'users but can you please add a comment 
> detailing why this is needed ?
> 
> Thanks,
> Eric
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

I'm not entirely sure myself, but under the recipes fails to build
wxwidgets without libxinerama on my box at least.

I'm using the overo-oe branch of openembedded, but it appears as though
they haven't made any changes to this recipe, so I sent the patch here.
I'm also using their configuration files if that matters.

This is my first time sending a patch via a mailing list, so should I
amend my commit with an additional line in the commit message to the
effect of "wxwidgets depends on libxinerama, which was missing from the
recipe" and then perform git send-email again as detailed in the wiki?
Is there some additional step to mark it as a revision to this patch?






More information about the Openembedded-devel mailing list