[oe] [PATCH] classes/gitpv.bbclass: use 'git describe' to for package version

[Otavio Salvador]

On Wed, Dec 15, 2010 at 11:01, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Wed, Dec 15, 2010 at 10:50:25AM -0200, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>  classes/gitpv.bbclass |   41 +++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 41 insertions(+), 0 deletions(-)
>>  create mode 100644 classes/gitpv.bbclass
>>
>> diff --git a/classes/gitpv.bbclass b/classes/gitpv.bbclass
>> new file mode 100644
>> index 0000000..c9496f1
>> --- /dev/null
>> +++ b/classes/gitpv.bbclass
>> @@ -0,0 +1,41 @@
>> +# gitpv.bbclass provides a PV variable which is a sortable version
>> +# with the output of "git describe".
>> +#
>> +# It can handle SRCREV = ${AUTOREV}, as well as SRCREV = "<hash>"
>> +
>> +PV = "${@get_git_pv(d)}"
>
> can you integrate it with
> classes/gitpkgv.bbclass ?

I can however I think the usage is different.

The gitpkgv does not use describe and if there's users of it (there's
no in recipes) we'd change it for them. That is wrong in my opinion.

So I thought about adding another class and not messing with it.

> get_git_pkgv() there is quite similar
> and after improving it with git describe you can use it here as ${GITPKGV}
>
> and maybe assign to PV only ?= as IMHO recipe should be able to say
> different base version than 0.0 or use it only in PKGV..

about assign to PV ?= I agree however why someone might want to use it
only in PKGV?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br