[oe] avoid addtask?

[Frans Meulenbroeks]

2010/12/24 Khem Raj <raj.khem at gmail.com>:
> On Fri, Dec 24, 2010 at 12:33 AM, Frans Meulenbroeks
> <fransmeulenbroeks at gmail.com> wrote:
>> I was wondering whether it is better to avoid addtask where easily possible.
>>
>
> If the tasks are logically inline in existing tasks then it would be
> ok. Although I dont know the big O notation of
> runqueue algorithm to ascertain the gain.

I was more considering the overhead starting and handling the task.
But I guess it will be marginally.
>
>> E.g. from one recipe:
>>
>> do_postpatch() {
>>        rm -rf patches && rm -rf .pc && mv -f debian/patches patches
>> && quilt push -av
>> }
>> addtask postpatch after do_patch before do_configure
>>
>>
>> Wouldn't it be simpler and probably even a little bit faster just to say:
>>
>> do_configure_prepend() {
>>        rm -rf patches && rm -rf .pc && mv -f debian/patches patches
>> && quilt push -av
>> }
>>
>
> Well this seems more like a patching task then configure to me.

True do_patch_append
>
>> (or if there is already a do_configure_prepend add the line to it)
>>
>> Currently we have 142 addtasks and some of these are definitely useful
>> and desirable but I feel a lot of these could easily be merged into
>> the previous or next task.
>>
>> How do you feel about this?
>>
>> Frans
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>