[oe] = ? UTF-8 ? B ? Ww== ? =oe= ? UTF-8 ? B ? XQ== ? = How to sane replace a path in a pkgconfig file ?

[Bernhard Reutner-Fischer]

On Sun, Feb 14, 2010 at 09:38:51PM +0100, bernhard.guillon at opensimpad.org wrote:
>> > classes/pkgconfig.bbclass suggests that .pc are fixed up in
>> > do_install_prepend() (why does the efl class duplicate this, btw?)
>> > and that this depends on stage.
>> 
>> Because the efl classes suck, they also override things like PACKAGES.
>> With new-style staging and the current state of e svn we should be able
>> to get rid of that crap altogether.
>> 
>> That reminds me, I wanted to add
>> 
>> do_configure_prepend() {
>> 	 autopoint
>> }
>> 
>> to those clase to make the modules build again.
>
>I found the problem for blackbox. The path is in -rlink-path and this is currently ignored by pkgconfig.bbclass.
>
>This fixed it on my system but I have no clue if this is a good idea at all :D
>
>diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
>index f3d9371..1da508f 100644
>--- a/classes/pkgconfig.bbclass
>+++ b/classes/pkgconfig.bbclass
>@@ -3,7 +3,7 @@ DEPENDS_prepend = "pkgconfig-native "
> do_install_prepend () {
> 
> for i in `find ${S}/ -name "*.pc" -type f` ; do 
>-            sed -i -e 's:-L${STAGING_LIBDIR}::g' -e 's:-I${STAGING_INCDIR}::g' $i
>+            sed -i -e 's:-L${STAGING_LIBDIR}::g' -e 's:-I${STAGING_INCDIR}::g' -e 's:-rpath-link,${STAGING_LIBDIR}::g' $i

I'd go for plain
sed -i -e 's:${STAGING_LIBDIR}::g' -e 's:${STAGING_INCDIR}::g' $i

to avoid massaging  -rpath / -Y / --library-path et al later on.
>         done
> }
>
>
>Should I prepare a proper patch for pkgconfig.bbclass and send it to the list or is this approach the wrong way?