[oe] {RFC] console-image.bb

[Frans Meulenbroeks]

2010/2/18 Koen Kooi <k.kooi at student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 18-02-10 11:11, Frans Meulenbroeks wrote:
>> 2010/2/18 Koen Kooi <k.kooi at student.utwente.nl>:
>> On 18-02-10 10:18, Frans Meulenbroeks wrote:
>>>>> 2010/2/17 Koen Kooi <k.kooi at student.utwente.nl>:
>>>>>
>>>>>>>> FYI: I popped a question three weeks ago.
>>>>>>>> Today Rolf asked me about the status in #oe.
>>>>>>>> As you can see above 4 people (Rolf, Mickey, Phil and me were in
>>>>>>>> favour of the proposal. In irc mckoan also backed the proposal.
>>>>>>>> There was one person opposed to it: you.
>>>>>>
>>>>>> And funnily enough I'm the maintainer, so I get the final say.
>>>>>
>>>>> Still wondering what makes you the maintainer.
>>>>>
>>>>> git log does not mention any changes for this file by you (apart from
>>>>> yesterdays revert):
>>>>> See http://cgit.openembedded.org/cgit.cgi/openembedded/log/recipes/images/console-base-image.bb
>>
>> Git doesn't track renames properly, using the parent of the
>> packages->recipes commit:
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded/log/packages/images/console-image.bb?id=fa6cd5a3b993f16c27de4ff82b42684516d433ba
>>
>>> The parent is http://cgit.openembedded.org/cgit.cgi/openembedded/log/packages/images/console-base-image.bb
>>> we're talking about console-base-image here.
>
> No, we are not talking about console-base-image, read the subject of
> this mail: "Re: [oe] {RFC] console-image.bb"
>
> Try doing 'git log --follow recipes/images/console-image.bb' in your OE
> checkout and see the ancestry of console-image for the past 3.5 years.

As I already explained in the 3rd message of this email I
misremembered the name when typing the message. See quoted text below.
This should also be clear from the context of the message
And the commit you reverted is also on console-base-image.bb:
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=8679a8574893ac8cd3beeebe2e62084b94660999
not console-image.bb

Rolf did not touch console-image and console-image does not contain
angstrom specifics.

Frans.


2010/1/30 Frans Meulenbroeks <fransmeulenbroeks at gmail.com>:
> 2010/1/30 Rolf Leggewie <no2spam at nospam.arcornews.de>:
>> Frans Meulenbroeks wrote:
>>> Wouldn't it be cleaner to rename ANGSTROM_EXTRA_INSTALL to e.g.
>>> DISTRO_EXTRA_INSTALL ?
>>
>> This has been discussed before, but not changed.  I think it made sense
>> back then and I think it makes sense now.
>>
>> I believe there is even a better name than DISTRO_EXTRA_INSTALL to be
>> found for the variable.  Maybe IMAGE_EXTRA_INSTALL?
>>
> Actually mistyped tye filename, it was console-base-image.bb
> and in the beginning it says that it is an angstrom bootstrap image,
> so having angstrom specific env vars in it makes sense, but guess the
> name then should be angstrom-console-base-image.bb, just like other
> images are prefixed with openmoko, nylon, opie, slugos and whatever
>