[oe] [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips

[Guo Hongruan]

Hi,

在 Sat, 02 Jan 2010 16:35:04 +0800，Holger Hans Peter Freyther  
<holger+oe at freyther.de> 写道:

> On Saturday 02 January 2010 08:34:34 Guo Hongruan wrote:
>> 1. Add mips entry for linux-uclibc into package_qa_get_machine_dict of
>>  insane.bbclass. Without it the insance check will fail due to key miss
>>  exception.
>
>>  2. Rewrite the complete qemumips/uClibc.machine, In the
>>  previous one, the TARGET_ARCH is set i386 (not mips). ---
>>  classes/insane.bbclass                             |    1 +
>
>
> Please split up the patch as there is no relationship between the two  
> things.
Sorry, I will. I found these bugs using the same test case.

> The first one is a nice catch and I thought we already had this. I can't
> comment on the second one.

The second patch is obvious. The qemumips/uClibc.machine was copied from  
qemux86/uClibc.machine without any modification. It causes the building  
for qemumips + uclibc failed.
>
> The other bit is... use "Signed-off-by:" on your patches if you want them
> included in OE. Only if you use the above they will show up in
> patchwork.openembedded.org which people go through to look at outstanding
> patches...

Signed-off-by? How to do it. Could you give me some links about this  
topics? I will google it
>
> thanks
> 	z.!
>
> PS: keep up the nice work :)
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


-- 
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com