[oe] [PATCH] Build fbv with JPEG and PNG enabled

[Paul Menzel]

Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
> Build fbv with jpeg and png enabled
> 
> Signed-off-by: Ulf Samuelsson <ulf.samuelsson at atmel.com>
> ---
>  recipes/fbv/fbv-1.0b/fbv-1.0b.patch |   12 ++++++++++++
>  recipes/fbv/fbv_1.0b.bb             |   23 +++++++++++++++--------
>  2 files changed, 27 insertions(+), 8 deletions(-)
>  create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> 
> diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> new file mode 100644
> index 0000000..6fbd1fb
> --- /dev/null
> +++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> @@ -0,0 +1,12 @@
> +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
> +--- fbv-1.0b-0rig/Makefile	2009-08-20 00:33:58.000000000 +0200
> ++++ fbv-1.0b/Makefile	2009-08-20 00:34:16.000000000 +0200
> +@@ -12,7 +12,7 @@
> + OBJECTS	= ${SOURCES:.c=.o}
> +
> + OUT	= fbv
> +-#LIBS	= -lungif -L/usr/X11R6/lib -ljpeg -lpng
> ++LIBS	= -L/usr/lib -ljpeg -lpng #-lungif
> +
> + all: $(OUT)
> + 	@echo Build DONE.
> diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
> index 04c7066..4a5bd6b 100644
> --- a/recipes/fbv/fbv_1.0b.bb
> +++ b/recipes/fbv/fbv_1.0b.bb
> @@ -1,25 +1,32 @@
>  DESCRIPTION = "Frame Buffer Viewer"
>  LICENSE = "GPL"
> -DEPENDS = "libpng"
> +DEPENDS = "libpng jpeg"
>  PR = "r1"

Should not this be increased because of the changed `DEPENDS`? Why is
`PR` not just a number?

>  SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
> -	   file://cross_compile.patch;patch=1"
> +	file://cross_compile.patch;patch=1 \
> +	file://fbv-1.0b.patch;patch=1 \
> +	"
> +
> +#inherit autotools

Please do not comment out code. Everything is under versioning control.

>  do_configure() {
> -	CC="${CC}" ./configure --without-libungif --without-bmp \
> -		--without-libjpeg
> +	CC="${CC}" ./configure --without-libungif
>  }
> 
>  do_compile() {
>  	oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
>  		CC="${CC}"
>  }
> +
>  do_install() {
>  	install -d ${D}${bindir}
> -        install -m 0755 fbv ${D}${bindir}
> +	install -m 0755 fbv ${D}${bindir}

What changed?

> -        # man
> -        install -d ${D}${mandir}/man1/
> -        install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> +# man
> +#	install -d ${D}${mandir}/man1/
> +#	install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
>  }

Why did you disable this? If it is not needed, please do it in a
separate patch or at least mention it in the commit message.

> +
> +PACKAGES = "fbv"
> +


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100120/92647838/attachment-0002.sig>