[oe] [PATCH] socat: Add version 1.7.1.2

[Paul Menzel]

Am Samstag, den 23.01.2010, 11:03 -0800 schrieb John Faith:
> Allow socat 1.7.1.2 to cross build.  In configure.in, the 4th value in
> AC_TRY_RUN() gives a default value for cross build environments since
> a test program cannot be run on the build system.  There are 2 places
> where AC_MSG_RESULT() is used instead of a default value which seems
> to result in code like "#define CRDLY_SHIFT" which breaks preprocessor
> checks like "#if CRDLY_SHIFT >= 0".
> 
> The patch gives default values in configure and configure.in for cross
> compiling and checks were added in the affected source.
> 
> Signed-off-by: John Faith <john at soundmetrics.com>

Thank you for your patch.

1. Applying your patch gives me warnings.

        $ git am /tmp/\[oe\]_\[PATCH\]_socat\:_Add_version_1.7.1.2 
        Applying: socat: Add version 1.7.1.2
        /srv/filme/oe/openembedded/.git/rebase-apply/patch:29: trailing whitespace.
         
        /srv/filme/oe/openembedded/.git/rebase-apply/patch:38: trailing whitespace.
         
        /srv/filme/oe/openembedded/.git/rebase-apply/patch:46: trailing whitespace.
         
        /srv/filme/oe/openembedded/.git/rebase-apply/patch:54: trailing whitespace.
         
        /srv/filme/oe/openembedded/.git/rebase-apply/patch:60: space before tab in indent.
         	IF_IP6    ("ipv6only",	&opt_ipv6_v6only)
        warning: squelched 13 whitespace errors
        warning: 18 lines add whitespace errors.

> ---
>  recipes/socat/files/socat-1.7.1.2-cross.patch |   98 +++++++++++++++++++++++++
>  recipes/socat/socat_1.7.1.2.bb                |   23 ++++++
>  2 files changed, 121 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/socat/files/socat-1.7.1.2-cross.patch
>  create mode 100644 recipes/socat/socat_1.7.1.2.bb
> 
> diff --git a/recipes/socat/files/socat-1.7.1.2-cross.patch b/recipes/socat/files/socat-1.7.1.2-cross.patch

[ … I do not no autotools.]

> diff --git a/recipes/socat/socat_1.7.1.2.bb b/recipes/socat/socat_1.7.1.2.bb
> new file mode 100644
> index 0000000..5bbb421
> --- /dev/null
> +++ b/recipes/socat/socat_1.7.1.2.bb
> @@ -0,0 +1,23 @@
> +SECTION = "console/network"
> +DEPENDS = "openssl readline"
> +DESCRIPTION = "Socat is a relay for bidirectional data \
> +transfer between two independent data channels."
> +LICENSE = "GPL"
> +PR = "r1"

You can start with `r0` I think.

> +
> +SRC_URI = "http://www.dest-unreach.org/socat/download/socat-1.7.1.2.tar.bz2 \

Can we do this more generic: `…/download/${P}.tar.bz2`.

> +           file://socat-1.7.1.2-cross.patch;patch=1 "
> +
> +inherit autotools
> +
> +do_configure() {
> +	# Override this function to avoid autoconf/automake/aclocal/autoheader
> +	# since config.h.in gets recreated.
> +	(cd ${S} && gnu-configize) || die "failure in running gnu-configize"
> +	oe_runconf
> +}
> +
> +do_install_prepend () {
> +	mkdir -p ${D}${bindir}
> +	install -d ${D}${bindir} ${D}${mandir}/man1
> +}

2. I cannot build your patch because checksums are missing [1].
3. Looking at the difference between `socat_1.3.2.1.bb` and
`socat_1.7.1.2.bb` there is not much. Could you factor that out into an
include file e. g. unify this?

Please fix this up and resend with `[PATCH v2]` in the subject line and
a note in the commit message.


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Checksums
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100123/3b23441f/attachment-0002.sig>