[oe] Request to revert latest devicekit patch
John Willis
John.Willis at Distant-earth.com
Sun Jan 24 18:26:33 UTC 2010
Rolf,
Replying to your mail on-list.
As the author of said patch if people want it reverted go ahead. It has my
ACK.
> Koen Kooi wrote:
> > On 24-01-10 12:35, Holger Hans Peter Freyther wrote:
> >> Can anyone ack the revert please?
> >
> > The commit says:
> >
> > Note: Another (maybe better) fix would be to package up docbook-xsl
> but
> > that is overkill for these two recipes.
>
> To introduce something new that patch breaks something for somebody
> else
> that was previously working. I thought it was commonly accepted that
> it's then the author's (and possibly the committer's) responsibility to
> come up with something better to fix this regression.
>
> > Wouldn't that be a better option than introducing a regression?
>
> The regression was introduced with the patch. Not by reverting it.
>
> A revert gets my ACK if this bothers Holger enough in his workflow. I
> would suggest Holger and David-John should talk about a time-frame in
> which David-John can cook up a proper patch. Based on this information
> a decision should be made if a revert is necessary in the meantime or
> not. I trust Holger's judgment here.
>
>
> PS: David-John, the whole discussion is at
> http://thread.gmane.org/gmane.comp.handhelds.openembedded/29524
As I stated in the original patch the correct fix is to sort out the
docbook-xsl packages but that was not something I had any intention at the
time to tackle (limited OE dev time and a seemingly infinite TODO list). I
may be able to look at it in the near future but as for being the best man
for the job, that I am not so sure about.
The sole reason for the patch was to fix a build failure on systems where
the host system docbook-xsl stuff was not available (or desired).
Reverting the -nonet will reintroduce dependencies on components being
installed on the host system outside OE but if that is fine then go for the
revert. I understood (at the time, this is back in October) that depending
on host items outside oe's -native was a 'very bad thing' (tm) ;). Maybe
worse than requiring an internet connection but I am not the person to judge
that.
I'll leave it to core OE devs to decide what is the lesser of 2 evils in
this case.
Regards,
John
More information about the Openembedded-devel
mailing list