[oe] [PATCH v2] socat: Add version 1.7.1.2

Khem Raj raj.khem at gmail.com
Mon Jan 25 17:42:15 UTC 2010


On Mon, Jan 25, 2010 at 8:50 AM, John Faith <john at soundmetrics.com> wrote:
> Holger Hans Peter Freyther wrote:
>>
>> On Sunday 24 January 2010 00:16:46 John Faith wrote:
>>
>>>
>>> Second try. Added package source checksums, changed PR to r0, and removed
>>>  some trailing whitespace in the patch.
>>>
>>
>> First of all, thank you for the contribution. I have one question. Why did
>> you need to patch the configure script? It should be automatically
>> regenerated in the do_configure stage?
>>
>>
>>
>
> Hi,
> Using the default do_configure() overwrote config.h.in which lacked #defines
> like HAVE_SIGACTION and broke compilation for me.  I imagine that the right
> thing to do would be to just to patch configure.in and recreate the
> configure script and config.h.in.  This page:
> http://www.gnu.org/software/hello/manual/gettext/config_002eh_002ein.html
> seems to indicate that its ok to manually maintain a config.h.in, so I
> wonder what do_configure() should do in this case when this file is included
> in the source.

autoheader is creating the config.h.in and do_configure will do it if
project is set
to maintain config.h.in automatically. Your option is to override do_configure
and invoke the only regeneration commands that are needed however fixing it in
configure.in would be best IMO because then autoheader will get it right too.

>
> ,
> John
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>




More information about the Openembedded-devel mailing list