[oe] [PATCH 1/9] xilinx-virtex4: new file

[Adrian Alonso]

Hi Frans,

Some comments in lines...

Regards

On Tue, Jul 13, 2010 at 1:01 AM, Frans Meulenbroeks <
fransmeulenbroeks at gmail.com> wrote:

> 2010/7/12 Adrian Alonso <aalonso00 at gmail.com>:
> > * New config machine, generic support for Xilinx
> >  Virtex4 platforms ml401, ml403, ml405, ml410
> > * Tested on ml405 target board, powerpc based ref
> >  design at http://github.com/aalonso/xilinx-ml405
> > * Target configuration handled in xilinx-bsp.bbclass
> >
> > Signed-off-by: Adrian Alonso <aalonso00 at gmail.com>
> > ---
> >  conf/machine/xilinx-virtex4.conf |   40
> ++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 40 insertions(+), 0 deletions(-)
> >  create mode 100644 conf/machine/xilinx-virtex4.conf
> >
> > diff --git a/conf/machine/xilinx-virtex4.conf
> b/conf/machine/xilinx-virtex4.conf
> > new file mode 100644
> > index 0000000..942b63f
> > --- /dev/null
> > +++ b/conf/machine/xilinx-virtex4.conf
> > @@ -0,0 +1,40 @@
> > +# Copyright (C) 2010, Adrian Alonso <aalonso00 at gmail.com>
> > +# Released under the MIT license (see packages/COPYING)
> > +#@TYPE: Machine
> > +#@Name: Xilinx Virtex4 FPGA Development Platform
> > +#@DESCRIPTION: Machine configuration for Xilinx Virtex4 family
> > +# Supported targets
> > +# ML403, ML405, ML410
> > +
> > +# Default arch can be overrided in local.conf
> > +TARGET_ARCH ?= "powerpc"
>
> Do we expect to be this machine to be powerpc only or would there be
> any chance that someone puts linux on microblaze on it?
> If so is this going to be in this file?
> If we think microblaze linux on this board will happen and not in this
> file perhaps make explicit in the machine name that it is ppc only.
> If microblaze on this board is unlikely it is afaik ok as it is.
>

I intent that the config machine can support both powerpc and microblaze
arch
thats why TARGET_* assignments are weak so they can be override in
local.conf
so I can preserve machine features without the need to add another machine
conf
file for microblaze.

Umm I think that kernel config file is an obstacle to achieve this,
because it would
pull powerpc settings unless I implement a mechanism to pull the correct
kernel
config file depending on the target arch. So for the moment the best option
is to
make this machine file powerpc specific.

If you are interested  on OE microblaze support take a look at [1], is just
matter to
add gcc support of "-shared" option to complete OE microblaze integration.

[1] http://gitorious.org/oe-microblaze

>
> > +TARGET_CPU  ?= "405"
> > +TARGET_FPU  ?= "soft"
> > +TARGET_TUNE ?= "ppc405"
> > +#tune for the selected cpu
> > +require conf/machine/include/tune-${TARGET_TUNE}.inc
> > +
> > +#ASSUME_PROVIDED += "virtual/kernel"
>
> I'd say remove the line above. It is harmless as it is comment but
> could lead to confusion.
> (or if it is useful for people to have this perhaps have a line or two
> of comment)
>
> > +PREFERRED_PROVIDER_virtual/kernel = "linux-xilinx"
> > +PREFERRED_VERSION_u-boot_xilinx-virtex4 = "u-boot-xilinx"
> > +
> > +KERNEL_IMAGETYPE = "uImage"
> > +
> > +MACHINE_FEATURES = "kernel26 apm ext2 vfat ethernet"
> > +MACHINE_EXTRA_RECOMMENDS = "kernel-modules"
> > +
> > +UBOOT_ENTRYPOINT ?= "0x00000000"
> > +UBOOT_LOADADDRESS ?= "0x00000000"
> > +
> > +# Xilinx EDK override hardware  definitions for xilinx-bsp
> > +# Include in your local.conf
> > +# XILINX_BSP_PATH = "complete path for Xilinx XPS project"
> > +# XILINX_BOARD = "ml410"
> > +
> > +# Don't use tty1
> > +USE_VT = "0"
> > +SERIAL_CONSOLE = "9600 ttyS0"
> > +
> > +# Device nodes add xsa for (system ace)
> > +IMAGE_DEVICE_TABLES = "files/device_table-minimal.txt \
> > +                       files/device_table_add-xsa.txt"
> > --
> > 1.7.1.1
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
Saludos
Adrian Alonso
http://aalonso.wordpress.com