[oe] [PATCH 02/10] xilinx-virtex4: new file

[Paul Menzel]

Am Freitag, den 30.07.2010, 10:42 -0500 schrieb Adrian Alonso:

Please improve the summary line to something like.

	xilinx-virtex4: Add machine config for Xilinx Virtex4 platforms.

»new file« is, at least for me, not useful.

> * New config machine, generic support for Xilinx
>   Virtex4 platforms ml401, ml403, ml405, ml410
> * Tested on ml405 target board, powerpc based ref
>   design at http://github.com/aalonso/xilinx-ml405
> * Target configuration handled in xilinx-bsp.bbclass
> 
> Signed-off-by: Adrian Alonso <aalonso00 at gmail.com>
> ---
>  conf/machine/xilinx-virtex4.conf |   37 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 37 insertions(+), 0 deletions(-)
>  create mode 100644 conf/machine/xilinx-virtex4.conf
> 
> diff --git a/conf/machine/xilinx-virtex4.conf b/conf/machine/xilinx-virtex4.conf
> new file mode 100644
> index 0000000..eeea44e
> --- /dev/null
> +++ b/conf/machine/xilinx-virtex4.conf
> @@ -0,0 +1,37 @@
> +# Copyright (C) 2010, Adrian Alonso <aalonso00 at gmail.com>
> +# Released under the MIT license (see packages/COPYING)
> +#@TYPE: Machine
> +#@Name: Xilinx Virtex4 FPGA Development Platform
> +#@DESCRIPTION: Machine configuration for Xilinx Virtex4 family
> +# Supported targets
> +# ML403, ML405, ML410

The commit message says ml401 too.

> +TARGET_ARCH = "powerpc"
> +TARGET_CPU  = "405"
> +TARGET_FPU  = "soft"
> +#tune for the selected cpu
> +require conf/machine/include/tune-ppc405.inc
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-xilinx"
> +PREFERRED_VERSION_u-boot_xilinx-virtex4 = "u-boot-xilinx"

As far as I can see, those recipes are added in later patches. Would not
that make this patch produce a non-working machine and therefore for
example also render `git bisect` useless.

If I was right, please reorder the patches. I do not know what the
preferred way of adding new machines is. A big patch with all needed
files or incremental ones.

> +KERNEL_IMAGETYPE = "uImage"
> +
> +MACHINE_FEATURES = "kernel26 apm ext2 vfat ethernet"
> +MACHINE_EXTRA_RECOMMENDS = "kernel-modules"
> +
> +UBOOT_ENTRYPOINT ?= "0x00000000"
> +UBOOT_LOADADDRESS ?= "0x00000000"
> +
> +# Xilinx EDK override hardware definitions for xilinx-bsp

1. What does »EDK« mean? Embedded Development Kit [1]? What does it
refer to? Sorry for my ignorance. I just found [2], but I do not know
what this has to do with OE.
2. s/override/overrides/ ?

[1] http://acronyms.thefreedictionary.com/EDK
[2] http://www.xilinx.com/ise/embedded/edk_docs.htm

> +# Include in your local.conf
> +# XILINX_BSP_PATH = "complete path for Xilinx XPS project"
> +# XILINX_BOARD = "ml410"
> +
> +# Don't use tty1
> +USE_VT = "0"
> +SERIAL_CONSOLE = "9600 ttyS0"
> +
> +# Device nodes add xsa for (system ace)
> +IMAGE_DEVICE_TABLES = "files/device_table-minimal.txt \
> +                       files/device_table_add-xsa.txt"


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100731/060752a7/attachment-0002.sig>