[oe] [PATCH] Change wget fetcher to use the runfetchcmd

Chris Larson clarson at kergoth.com
Wed Jun 9 15:08:18 UTC 2010


On Tue, Jun 8, 2010 at 12:40 PM, Ryan Phillips <ryan at trolocsis.com> wrote:

> We were having problems with wget fetching through our proxy. One of
> the problems stemmed from quoting around the environment variables,
> and the other appears to be from legacy code not calling into
> runfetchcmd within the wget fetcher.


Seems fine for the most part.  One quick question: Can you explain why
you're escaping the double quotes in your quoting of the env vars, when its
contained in a singled quoted string, not double?  Of course, we should
really switch that code over to using subprocess, passing the environment as
a mapping, rather than this sort of shell script emission.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics



More information about the Openembedded-devel mailing list