[oe] [PATCH] qt4-embedded: rename qtdemo file

[Leon Woestenberg]

Hello,

On Wed, Jun 9, 2010 at 4:08 PM, Phil Blundell <philb at gnu.org> wrote:
> On Wed, 2010-06-09 at 15:55 +0200, Marco Cavallini wrote:
>> #Append an E to the qtdemo file
>> if [${QT_LIBINFIX} == "E"] ; then
>>           mv ${D}${bindir}/qtdemo ${D}${bindir}/qtdemo${QT_LIBINFIX}
>> fi
>
> I think you need some quotes around ${QT_LIBINFIX} in the argument to [,
> otherwise you are liable to get an error if the variable is empty.  It
> might also make more sense to test something like '-n "${QT_LIBINFIX"',
> rather than testing for it being 'E' specifically.  But yes, clearly the
> current code is not satisfactory in the case of an empty infix.
>

while we're at it, isn't "-embedded" a much more friendly distinction
that using "E" ?

Regards,
-- 
Leon