[oe] additional bitbake test

[Chris Larson]

On Sat, May 29, 2010 at 2:36 AM, Frans Meulenbroeks <
fransmeulenbroeks at gmail.com> wrote:

> 2010/5/28 Chris Larson <clarson at kergoth.com>:
> > On Thu, May 27, 2010 at 11:36 PM, Frans Meulenbroeks <
> > fransmeulenbroeks at gmail.com> wrote:
> >
> >> Hi,
> >>
> >> I'd like to propose to add a test in bitbake to see if an overlay dir
> >> exists when specifying overlays.
> >>
> >> In the past I bumped into a problem where BBFILE_PATTERN_local =
> >> "^${OE_TOPDIR}/myoverlay/recipes" was not processed properly because
> >> OE_TOPDIR was not passed using BB_ENV_EXTRAWHITE, resulting in the
> >> regexp match with the dir always returning false due to OE_TOPDIR not
> >> being expanded.
> >> A simple test could warn users against errors like this one.
> >>
> >
> > Hmm, I'm not sure how best to implement the warning.  I'd rather not
> grep,
> > and we don't currently have a way to determine what variables a given
> value
> > references.  I guess we could notice if a given pattern didn't match any
> > files in BBFILES, and warn on that.  Does that sound reasonable?
>
> That sounds quite good to me.
>

Okay, sorry for the delay, but this is in master now.  Example:

kergoth at auron ~/C/o/bitbake> bitbake nano
NOTE: Handling BitBake files: - (8453/8453) [100 %]
Parsing of 8453 .bb files complete (7978 cached, 475 parsed). 8485 targets,
319 skipped, 1 masked, 0 errors.
WARNING: No bb files matched BBFILE_PATTERN_foo
'^/home/kergoth/Code/oe/foo/'
NOTE: Resolving any missing task queue dependencies
NOTE: Preparing runqueue


> > Aside: the fact that a nonexistant var is left as is, to be expanded in
> > shell, is horrible, imo.  They should expand to the empty string when
> unset,
> > or error, or something.
>


> I'm inclined to say error. If a default it wanted an assignment can be
> done somewhere.
> Better make the problem explicit
>

Agreed.  I'll add this to the bitbake TODO for long term.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics