[oe] [PATCH] package_ipk.bbclass DON'T PUSH THIS, but PLEASE read it

[Martin Jansa]

On Wed, Mar 03, 2010 at 08:19:37PM +0100, Martin Jansa wrote:
> On Wed, Mar 03, 2010 at 01:07:11PM +0000, Richard Purdie wrote:
> > Its a serious bug I agree but a very hard one to fix. The correct fix is
> > to have staging under full control of a packaging system, then when you
> > clean packages, all the right bits are actually removed.
> > 
> > In that sense this is no better or worse than the other 101 ways you can
> > break staging.
> 
> Fair enough, thanks for reply.
> 
> > So in summary, no easy fix, we need to fix the big general problem -
> > packaged staging needs to be on by default and used by everything. Only
> > then will we nail all these problems.
> 
> So I'll continue to use 
> find tmp/pkgdata -name ${PN}\* -exec rm -rf {} \;
> when I see non-existent lockfile path.
> 
> Or maybe try this little patch and watch what will break:
> diff --git a/classes/packagedata.bbclass b/classes/packagedata.bbclass
> index 86f18a9..e38ff3c 100644
> --- a/classes/packagedata.bbclass
> +++ b/classes/packagedata.bbclass
> @@ -56,7 +56,8 @@ python read_subpackage_metadata () {
>         for pkg in bb.data.getVar('PACKAGES', d, 1).split():
>                 sdata = read_subpkgdata(pkg, d)
>                 for key in sdata.keys():
> -                       bb.data.setVar(key, sdata[key], d)
> +                       if bb.data.getVar(key, d, None) == None:
> +                               bb.data.setVar(key, sdata[key], d)
>  }

First thing broken is 
inherit update-alternatives in sysvinit
which didn't set init link in postinst and my image didn't boot, so now
I agree that it's harder than it seems and that "patch" was really bad
idea.

Regards,

-- 
uin:136542059                jid:Martin.Jansa at gmail.com
Jansa Martin                 sip:jamasip at voip.wengo.fr 
JaMa