[oe] [PATCH (updated)] autotools.bbclass: enhanced oe_runconf() to accept quoted arguments

Chris Larson clarson at kergoth.com
Sun May 23 17:11:37 UTC 2010


On Sun, May 23, 2010 at 9:45 AM, Enrico Scholz <
enrico.scholz at sigma-chemnitz.de> wrote:

> Chris Larson <clarson at kergoth.com> writes:
>
> >> >> This patch allows to pass quoted strings in EXTRA_OECONF.
> >>
> > I fail to see how this is a problem.  Seems to work fine for every
> > other app, including make.
>
> EXTRA_OEMAKE handling is implemented as
>
> | ${MAKE} ${EXTRA_OEMAKE} "$@"
>
> but EXTRA_OECONF as
>
> | cfgcmd="... ${EXTRA_OECONF} $@"
> | $cfgcmd
>
>
> 'make' arguments are expanded by bitbake which preserve the quoting.
>
> The EXTRA_OECONF content was put into a shell variable and this variable
> be executed.  This does not preserve quoting (and I am not aware of any
> way how this can be with variable assignments).
>
>
> > Is configure's argument passing that stupid, that it can't split by =
> > and use the right side for the value?
>
> It is not a configure issue, but a shell one.
>

Ahh, I see, that makes it clear, thanks for clarifying.  I have a local
patch that turns cfgcmd into a bitbake variable, and runs ${cfgcmd} "$@".
What do you think about that approach as an alternative?  It makes it easier
for future metadata tracking if we don't use shell variables unless we
really have to, and would make its behavior consistent with
oe_runmake/EXTRA_OEMAKE.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics



More information about the Openembedded-devel mailing list