[oe] [PATCH 3/5 v2] linux-xilinx-ml507: update kernel version

Adrian Alonso aalonso00 at gmail.com
Mon May 24 16:24:32 UTC 2010


Hi,

On Mon, May 24, 2010 at 8:55 AM, Stefan Schmidt
<stefan at datenfreihafen.org>wrote:

> Hello.
>
> On Wed, 2010-05-19 at 09:53, Adrian Alonso wrote:
> >
> > I have been looking on how to reorder the patch,
> > but I'm still a git newbie :( and I don't quite well
> > understand how to regenerate my patch sets with
> > modifying the git log history, what I'm been doing
> > is to create a new branch fix my patchs and resend
> > them, thats clearly wrong.
>
> No, thats good. What I normally do when I prepare a change that will
> contain
> more then 2 patches is that I'm creating a branch for this. If I found a
> bug
> later or people point them out to me in a review I will rework the patches
> in
> this branch and resend.
>
> For the rework process you have a lot tools in git's toolbox, but I agree
> that
> they are are not the easiest ones. Still once I understood them I never
> want to
> miss them again. :)
>
> > Can you remove the patchs send on 2010-04-27 and
> > from the second patch set remove patch 3 and 4;
> > and use the path attached to make git bisec happy.
>
> I'm build testing this combination right now. One question that is still
> open is
> about the USE_VT in your first patch. Why did you comment it out? Something
> like
> this should be mentioned in the changelog.
>
> Yep I forgot to comment why i disable this option, it disables virtual
terminal, i think in
kernel options (not sure); disabling USE_VT I can have xserver running
otherwise fails
config files for machines that have by default graphical support don't
include this option
and i saw that only machines that doesn't have graphical support use this
option to
explicitly disable it.

Since we are in a dynamic architecture where display support can be included
or not
in the hardware model, i think that leaving the option in the config file is
a good idea
and just add some comments mentioning when this option is useful.

Thanks for your help.

regards
> Stefan Schmidt
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
Saludos
Adrian Alonso
http://aalonso.wordpress.com



More information about the Openembedded-devel mailing list