[oe] [PATCH] sanity.bbclass: Barf if TMPDIR has trailing forward slash

[Frans Meulenbroeks]

2010/5/26 Khem Raj <raj.khem at gmail.com>:
> * Unknowingly many developers run into this issue and
>  painful part it that the problems start happening almost
>  when build it complete and the errors are unrelated to cause
>  see http://www.mail-archive.com/angstrom-distro-devel@linuxtogo.org/msg02922.html
>
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  classes/sanity.bbclass |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass
> index dfb3010..88672ba 100644
> --- a/classes/sanity.bbclass
> +++ b/classes/sanity.bbclass
> @@ -112,11 +112,18 @@ def check_sanity(e):
>        oes_bb_conf = data.getVar( 'OES_BITBAKE_CONF', e.data, True )
>        if not oes_bb_conf:
>                messages = messages + 'You do not include OpenEmbeddeds version of conf/bitbake.conf. This means your environment is misconfigured, in particular check BBPATH.\n'
> -
>        #
> -       # Check that TMPDIR hasn't changed location since the last time we were run
> +       # get TMPDIR and use it in following two checks
>        #
>        tmpdir = data.getVar('TMPDIR', e.data, True)
> +       #
> +       # check if tmpdir has traling '/'
> +       #
> +       if tmpdir[-1] == "/":
> +               messages = messages + "Your TMPDIR has trailing '/' (forward slash), this can cause autotools lamangler fail regexp matches when munging .la files. Please remove it.\n\t"
> +       #
> +       # Check that TMPDIR hasn't changed location since the last time we were run
> +       #
>        checkfile = os.path.join(tmpdir, "saved_tmpdir")
>        if os.path.exists(checkfile):
>                f = file(checkfile, "r")
> --
> 1.7.0.4
>

Tested. works great for me so:
Acked-By: fransmeulenbroeks at gmail.com