[oe] Faking sign offs is bad

[Frans Meulenbroeks]

2010/5/29 Koen Kooi <k.kooi at student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> It seems some people have taken to faking sign off in patches, which is
> a bad thing. I would like to propose to revert anything that has fake
> signed-off-by lines.
>
> Case in point:
> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=28bc48904e31c3a63cf5a60bc005ed8fb359cc52
>
> Can that please get reverted? Andrea didn't ask me for a sign off and I
> didn't give one.

Andrea, do you want to comment on this? (or explain it)

Without knowing  the other side of the story I won't comment on this
specific example, but I would like to say something on it in general.
Personally I feel that faking sign-off's or acked-by's is very bad.
If this happens due to an accident or unawareness, I'm inclined to
give the person a second chance, but if it happens repeatedly or
intentionally, I suggest a revocation of commit rights.

And in order to avoid yes/no discussions I strongly suggest that
people express their acks in a way that it can be traced back should
any argument arise (e.g. by ack-ing by mail or on a logged irc
channel).

Frans.

>
> Apart from that, the commit is bogus, it just adds a
> 'udev/udev-151/udev-compat-static.patch' file in ${S} (of all places!)
> instead of actually patching the udev init file.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFMAOBzMkyGM64RGpERApnUAJ9ZTsHRLSeP2ZEFdqGuzReFNhDjfQCgrB38
> ddIujBP67BVQSsk6IBXZBJc=
> =ihUE
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>