[oe] Faking sign offs is bad

Andrea Adami andrea.adami at gmail.com
Sat May 29 17:09:24 UTC 2010


>> Apart from that, the commit is bogus, it just adds a
>> 'udev/udev-151/udev-compat-static.patch' file in ${S} (of all places!)
>> instead of actually patching the udev init file.
>
> The hack must be temporarly.
> I though tit's more clean if we overwrite the file than diffing and patching it.
> Perhaps I was wrong.
>
> Andrea
>

Oh, I see now...yes..my bad:

I had locally some more changes, which got lost importing your
modified init. 3 magic lines.

do_configure_prepend() {
        cp ${S}/patches/udev-compat-static.patch ${S}/init
}

Please forget: I'm preparing a proper v2 patch to be sent on the ML.

Sorry again for the noise

Andrea




More information about the Openembedded-devel mailing list