[oe] [PATCH] vlc_1.1.4.1: add `lua5.1` to `DEPENDS`

[Khem Raj]

On Wed, Nov 3, 2010 at 10:55 AM, Dallas Foley <dfoley at telus.net> wrote:
> On 10-11-03 02:28 AM, Paul Menzel wrote:
>>
>> Date: Wed, 3 Nov 2010 09:52:36 +0100
>>
>> After VLC 1.0.6, being the latest version in OE until addition of 1.1.4.1
>> in commit 30e362 [2], some interfaces were implemented in Lua in VLC 1.1.0
>> [1].
>>
>>        Interfaces:
>>         * Renamed the legacy rc, telnet and http interfaces to oldrc,
>> oldtelnet and oldhttp.
>>         * rc, telnet and http are now implemented using the lua interface
>> system.
>>
>> Task `configure` fails with the following error message.
>>
>>        […]
>>        | checking for LUA... no
>>        | configure: WARNING: lua5.1 not found, trying lua>= 5.1 instead
>>        | checking for LUA... no
>>        | checking lua.h usability... no
>>        | checking lua.h presence... no
>>        | checking for lua.h... no
>>        | checking lauxlib.h usability... no
>>        | checking lauxlib.h presence... no
>>        | checking for lauxlib.h... no
>>        | checking lualib.h usability... no
>>        | checking lualib.h presence... no
>>        | checking for lualib.h... no
>>        | checking for luaL_newstate in -llua5.1 ... no
>>        | checking for luaL_newstate in -llua51 ... no
>>        | checking for luaL_newstate in -llua ... no
>>        | configure: error: Could not find lua. Lua is needed for some
>> interfaces (rc, telnet, http) as well as many other custom scripts. Use
>> --disable-lua to ignore this error.
>>        | ERROR: Function do_configure failed
>>        NOTE: package vlc-1.1.4.1-r0: task do_configure: Failed
>>        […]
>>
>> Adding `lua5.1` to `DEPENDS` is chosen in favor of disabling it.
>>
>> [1]
>> http://git.videolan.org/?p=vlc.git;a=commitdiff;h=3c1df96cda8086f605f2eacaa5653c9e43ec45ac
>> [2]
>> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=30e362c22a49521ebeef9bed1f0c58902b7dc50b
>>
>> Signed-off-by: Paul Menzel<paulepanter at users.sourceforge.net>
>> ---
>>  recipes/vlc/vlc_1.1.4.1.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/vlc/vlc_1.1.4.1.bb b/recipes/vlc/vlc_1.1.4.1.bb
>> index d4535a5..ef764c1 100644
>> --- a/recipes/vlc/vlc_1.1.4.1.bb
>> +++ b/recipes/vlc/vlc_1.1.4.1.bb
>> @@ -10,7 +10,7 @@ SRC_URI[sha256sum] =
>> "61c9ea30a17ea40c6ccbfd507026e5c83ad9e0691f221d3667c8e49696
>>
>>  # ffmpeg from git (library version =>  52) is required
>>  # libtool-native must be>= 2.2.4
>> -DEPENDS += "libdvdcss libdvdread"
>> +DEPENDS += "libdvdcss libdvdread lua"
>>
>>  EXTRA_OECONF += "\
>>        --enable-dvdread \
>>
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> I seem to need lua5.1 and lua5.1-native in DEPENDS for this vlc as opposed
> to just lua.
> ie. DEPENDS += "libdvdcss libdvdread lua5.1 lua5.1-native"
>
> I doubt this has anything to do with it, but I am using
> DISTRO="angstrom-2010.x"
> and setting
> ANGSTROM_LIBTOOL_VERSION = "2.2.6b"
> LIBTOOL_HAS_SYSROOT = "no"
> only because apache2 does not configure with the newer libtool
>

did you report the apache problem and details about it before ?
if not the please do. I would say we should find the reasoning when we
add something to DEPENDS
the addition is simple but impact may be too far reaching.

>
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>