[oe] [PATCH] metadata_scm.bbclass: get the metadata revision for current HEAD

[Chris Larson]

On Wed, Nov 3, 2010 at 5:13 PM, Martin Jansa <martin.jansa at gmail.com> wrote:

> On Wed, Nov 03, 2010 at 04:55:52PM -0700, Chris Larson wrote:
> > On Wed, Nov 3, 2010 at 3:40 PM, Khem Raj <raj.khem at gmail.com> wrote:
> >
> > > Currently we report wrong revision when we build from branches not
> based
> > > on master because we only fetch the HEAD value which is remote master
> > > This patch makes it to report the HEAD of whatever branch one has
> > > checked out.
> > >
> >
> > This doesn't make sense.  The HEAD ref always points to the current
> checked
> > out commit or branch, it is *not* specific to master.
>
> No it does make sense, because it fixes my <unknown> METADATA_REVISION :).
>
> Acked-by: Martin Jansa <Martin.Jansa at gmail.com>
>
> in my R/W checkout I have it right even before patch
>
> bitbake at jama ~/oe $ git show-ref HEAD
> b3246d96069fd11caee42ec6ebcbf6dca2d62449 refs/remotes/origin/HEAD


No, this is broken.  It shouldn't be determining the METADATA_REVISION from
a ref you don't even have checked out.  Right now it's pulling the HEAD ref
from upstream, it should be pulling the local HEAD ref.  So NACK on this
patch, the metadata revision code needs to be fixed to either not use
show-ref or pass the necessary args to not operate based on a HEAD of a
remote.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics