[oe] [PATCH v2] TI tools - make EULA unpack work when /opt is writeable

[Maupin, Chase]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> Stefan Schmidt
> Sent: Saturday, November 06, 2010 9:11 AM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [PATCH v2] TI tools - make EULA unpack work when /opt is
> writeable
> 
> Hello.
> 
> On Sat, 2010-10-09 at 08:52, Gary Thomas wrote:
> > On 08/28/2010 03:07 AM, Gary Thomas wrote:
> > >This patch addresses the problem where the TI tools that need
> > >the EULA unpack into the wrong place if the user has write
> > >permission in /opt. The current behaviour of expecting the
> > >unpacker to fall back to the $HOME environment variable should
> > >not be relied on. The patch changes the unpack step to use
> > >the --prefix= option which will always work.
> > >
> > >Version 2:
> > >* Update patch to be against org.openembedded.dev branch
> > >* Incorporate full description into patch
> >
> > What about this patch?  It's been nearly 6 weeks and no discussion
> > or anything.
> >
> > The problem persists in today's tree.
> 
> Can we have a comment form the TI devs here?

This looks OK to me.  Only comment I have is whether the '/' is needed in the following line with the TI_BIN_UNPK_WDEXT option already add a '/'.  I guess while not technically necessary it would keep this code working if someone didn't define TI_BIN_UNPK_WDEXT with a leading '/'.

wdext = workdir + '/' + wdext

Sorry for the previous lack of response.  Thank you for the patch and fixing this issue.

> 
> regards
> Stefan Schmidt
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel