[oe] X-load git : add patch for am3517-crane support

Paul Menzel paulepanter at users.sourceforge.net
Mon Nov 22 13:57:20 UTC 2010


Dear Anil,


Am Montag, den 22.11.2010, 16:58 +0530 schrieb Anil Kumar Mamidala:

> Please find the attached x-boot patch to support am3517-crane board.

Thank you for your patch.

> From 95403dddb0f2a862bf04b8755eabfa153820272e Mon Sep 17 00:00:00 2001
> From: Anil Kumar <anilm at mistralsolutions.com>
> Date: Fri, 19 Nov 2010 11:23:21 +0530
> Subject: [PATCH] Applied patch on x-load for AM3517 Crane board support
> 
> Signed-off-by: Anil Kumar <anilm at mistralsolutions.com>

The subject in your attached patch differs from the more correct one of
your message. Please fix this with for example `git commit --amend` and
resend the patch marked with `[PATCH v2]`. (`git send-email` does take
care of everything.) [1]

Please also add a short note to the commit message with information to
the board, a link to the product information and maybe a short summary
if the board works fine with the current state in OE. What distribution
did you use for testing? I just saw, that you included some of these
information in the patch adding the machine config. That is fine too.
But please extend it.

Lastly please add a note to your patch where you submitted your patch
for upstream inclusion [2].

Looking at your other patches it seems there should be a certain order
in which your patches should be applied marked by `[PATCH 1/6]` and so
on. I guess first the patches for `u-boot`, `x-load` and `linux…`. And
only in the end the new machine config.

I guess my comments will apply to your other patches too. Please resend
the whole series.


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Policy
[2] http://wiki.openembedded.org/index.php/Push_patches_upstream
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20101122/1a767f6e/attachment-0002.sig>


More information about the Openembedded-devel mailing list