[oe] mixing `vname_append` with `+=` (was: [PATCH v2] strace_4.5.20.bb: Fix build on mips{, el} when DISTRO_FEATURES lacks "largefile".)

[Paul Menzel]

Am Dienstag, den 23.11.2010, 13:44 +0100 schrieb Andreas Oberritter:
> On 11/23/2010 01:37 PM, Andreas Oberritter wrote:
> > On 11/23/2010 04:27 AM, Graham Gower wrote:
> >> diff --git a/recipes/strace/strace_4.5.20.bb b/recipes/strace/strace_4.5.20.bb
> >> index 873ce52..086a4d7 100644
> >> --- a/recipes/strace/strace_4.5.20.bb
> >> +++ b/recipes/strace/strace_4.5.20.bb
> >> @@ -4,9 +4,13 @@ LICENSE = "GPL"
> >>  PR = "r0"
> >>  
> >>  DEFAULT_PREFERENCE = "-1"
> >> +DEFAULT_PREFERENCE_mips = "1"
> >> +DEFAULT_PREFERENCE_mipsel = "1"
> >>  
> >>  SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.bz2 \
> >>            "
> >> +SRC_URI_append_mipsel += " file://mips-nolargefile.patch "
> >> +SRC_URI_append_mips += " file://mips-nolargefile.patch "
> > 
> > I think it would be better to apply this patch unconditionally, because
> > it doesn't impose negative effects on other archs, and future patches
> > which might only get compile-tested on other archs must make sure that
> > mips-nolargefile.patch still applies.
> 
> Albeit, the correct syntax would be:
> SRC_URI_append_mipsel = " file://mips-nolargefile.patch"

Not necessarily. Quoting the user manual [1].

        Note that the appended information is a variable itself, and
        therefore it's possible to use += or =+ to assign variables to
        the _append information:

Although I do not know about the advantages or disadvantages.


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/usermanual.html#recipes_syntax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20101125/d905b529/attachment-0002.sig>