[oe] [REGRESSION] [PATCH] glib-1.2: merged native and non-native recipes

[Tom Rini]

Tom Rini wrote:
> Paul Menzel wrote:
>> Dear Fahad, dear Tom,
>>
>>
>> Am Donnerstag, den 09.09.2010, 11:31 +0200 schrieb Vitus Jensen:
>>
>>> On Wed, 8 Sep 2010, Fahad Usman wrote:
>>>
>>>> * removed the glib-1.2-native_1.2.10.bb file
>>>> * added NATIVE_INSTALL_WORKS = "1"
>>>> * added BBCLASSEXTEND = "native"
>>>> * converted do_stage of native recipe to do_install_virtclass-native 
>>>> in the combined recipe
>>>> * added DEPENDS_virtclass-native = "" to avoid dependencies loops
>>>> * added gettext in inherit because it was needed by the native recipes
>>>> * bumped PR
>>>>
>>>> Signed-off-by: Fahad Usman <fahad_usman at mentor.com>
>>>> ---
>>>> recipes/glib-1.2/glib-1.2-native_1.2.10.bb |   49 
>>>> ----------------------------
>>>> recipes/glib-1.2/glib-1.2_1.2.10.bb        |   20 ++++++++++-
>>>> 2 files changed, 18 insertions(+), 51 deletions(-)
>>>
>>>> diff --git a/recipes/glib-1.2/glib-1.2_1.2.10.bb 
>>>> b/recipes/glib-1.2/glib-1.2_1.2.10.bb
>>>> index 72ee826..67266d4 100644
>>>> --- a/recipes/glib-1.2/glib-1.2_1.2.10.bb
>>>> +++ b/recipes/glib-1.2/glib-1.2_1.2.10.bb
>>>> @@ -4,7 +4,8 @@ SECTION = "libs"
>>>> PRIORITY = "optional"
>>>> LICENSE = "LGPL"
>>>> DEPENDS = "glib-1.2-native"
>>>> -PR = "r4"
>>>> +DEPENDS_virtclass-native = ""
>>>> +PR = "r5"
>>> I don't know if everyone thinks so but I feel the following line is 
>>> more elegant:
>>>
>>> DEPENDS_pn-glib-1.2 += "glib-1.2-native"
>>>
>>> You skip the DEPENDS_virtclass-native line and may use the "+=" 
>>> operator.
>>
>> […]
>>
>> Tom committed an updated patch in 44af05 [1]. Unfortunately building the
>> recipe fails for me in `do_configure()`.
>>
>>         […]
>>         | checking for arm-oe-linux-gnueabi-gcc... 
>> arm-oe-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon 
>> -mfloat-abi=softfp -mthumb-interwork -mno-thumb
>>         | checking whether the C compiler works... no
>>         | configure: error: in 
>> `/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/glib-1.2-1.2.10-r5/glib-1.2.10': 
>>
>>         | configure: error: C compiler cannot create executables
>>         | See `config.log' for more details.
>>         | ERROR: Function do_configure failed
>>         NOTE: package glib-1.2-1.2.10-r5: task do_configure: Failed
>>         […]
>>
>> Do you know what might cause this? Reverting this commit the recipe can
>> be build.
> 
> I just built it for angstrom-2008.1 / beagleboard (target and native). 
> I've kicked off a minimal/eglibc/beagleboard build now.

So, a funny thing happened somewhere:

$ (source bitbake.rc ; DISTRO=minimal LIBC=eglibc MACHINE=beagleboard 
bitbake glib-1.2 -e ) | grep ^DEPENDS
DEPENDS_virtclass-nativesdk="autoconf-native automake-native 
libtool-native libtool-cross gnu-config-native coreutils-native 
virtual/arm-oe-linux-gnueabi-gcc virtual/libc"
DEPENDS_virtclass-native="autoconf-native automake-native libtool-native 
libtool-cross gnu-config-native coreutils-native 
virtual/arm-oe-linux-gnueabi-gcc virtual/libc"
DEPENDS="glib-1.2-native"
DEPENDS_GETTEXT="gettext gettext-native virtual/libiconv virtual/libintl"
DEPENDS_pn-glib-1.2="glib-1.2-native"

I believe, from Chris hammering this into my head a few times 
previously, the way that the pn-foo override is applied, the entire 
contents of VAR_pn-foo will replace VAR.  IOW, DEPENDS_pn-glib-1.2 += 
"..." will append to DEPENDS_pn-glib-1.2 and then overwrite DEPENDS.

I'll to and fix everything a git grep shows shortly.

-- 
Tom Rini
Mentor Graphics Corporation