[oe] [PATCH] gtk+_2.20.1: add `pango-native` to `DEPENDS`

[Frans Meulenbroeks]

2010/10/8 Paul Menzel <paulepanter at users.sourceforge.net>:
> Dear OE folks,
>
>
> I am still testing this patch. But since the new testing cycle will start soon I am sending this out already.
>
>
> Thanks,
>
> Paul
>
> 8<-------------------------------------------------------------------->8
> Date: Thu, 7 Oct 2010 13:43:58 +0200
>
> Since two or three days I am not able to build `gtk+_2.20.1.bb` anymore. I tried to revert to `gtk+.inc` 9730a2 [1] with
>
>    git checkout 9730a28e669931fee601756e949bb210999b4b81 recipes/gtk+/gtk+.inc
>
> but it did not help. I do still get the same error.
>
>    | /oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/bin/g-ir-scanner  --add-include-path=../gdk-pixbuf --namespace=Gdk --nsversion=2.0 --libtool="/bin/sh ../i686-linux-libtool"  --include=Gio-2.0 --include=GdkPixbuf-2.0 --include=Pango-1.0   --library=libgdk-x11-2.0.la --strip-prefix=Gdk --add-include-path=../gdk-pixbuf -DG_LOG_DOMAIN=\"Gdk\" -DGDK_COMPILATION -I.. -I../gdk -I../gdk-pixbuf -DG_DISABLE_CAST_CHECKS -pthread -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/glib-2.0 -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/lib/glib-2.0/include -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/pango-1.0 -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/cairo -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/pixman-1 -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/freetype2 -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/libpng12 -I/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/include/gio-unix-2.0/      gdk.h gdkapplaunchcontext.h gdkcairo.h gdkcolor.h gdkcursor.h gdkdisplay.h gdkdisplaymanager.h gdkdnd.h gdkdrawable.h gdkevents.h gdkfont.h gdkgc.h gdki18n.h gdkimage.h gdkinput.h gdkkeys.h gdkkeysyms.h gdkpango.h gdkpixbuf.h gdkpixmap.h gdkprivate.h gdkproperty.h gdkregion.h gdkrgb.h gdkscreen.h gdkselection.h gdkspawn.h gdktestutils.h gdktypes.h gdkvisual.h gdkwindow.h gdk.c gdkapplaunchcontext.c gdkcairo.c gdkcolor.c gdkcursor.c gdkdisplay.c gdkdisplaymanager.c gdkdnd.c gdkdraw.c gdkevents.c gdkfont.c gdkgc.c gdkglobals.c gdkimage.c gdkkeys.c gdkkeyuni.c gdkoffscreenwindow.c gdkpango.c gdkpixbuf-drawable.c gdkpixbuf-render.c gdkpixmap.c gdkpolyreg-generic.c gdkrectangle.c gdkregion-generic.c gdkrgb.c gdkscreen.c gdkselection.c gdkvisual.c gdkwindow.c gdkwindowimpl.c gdkenumtypes.c gdkenumtypes.h x11/checksettings.c x11/gdkapplaunchcontext-x11.c x11/gdkasync.c x11/gdkcolor-x11.c x11/gdkcursor-x11.c x11/gdkdisplay-x11.c x11/gdkdnd-x11.c x11/gdkdrawable-x11.c x11/gdkevents-x11.c x11/gdkfont-x11.c x11/gdkgc-x11.c x11/gdkgeometry-x11.c x11/gdkglobals-x11.c x11/gdkim-x11.c x11/gdkimage-x11.c x11/gdkinput-none.c x11/gdkinput-x11.c x11/gdkinput-xfree.c x11/gdkinput.c x11/gdkkeys-x11.c x11/gdkmain-x11.c x11/gdkpixmap-x11.c x11/gdkproperty-x11.c x11/gdkscreen-x11.c x11/gdkselection-x11.c x11/gdksettings.c x11/gdkspawn-x11.c x11/gdktestutils-x11.c x11/gdkvisual-x11.c x11/gdkwindow-x11.c x11/gdkxftdefaults.c x11/gdkxid.c x11/xsettings-client.c x11/xsettings-common.c libgdk-x11-2.0.la Makefile --output Gdk-2.0.gir
>    | Couldn't find include 'Pango-1.0.gir' (search path: ['../gdk-pixbuf', '../gdk-pixbuf', '/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/share/gir-1.0', '/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/share/gir-1.0', '/usr/share/gir-1.0', '/oe/build-minimal-eglibc/minimal-dev/sysroots/i686-linux/usr/share/gir-1.0'])
>
> `Pango-1.0.gir` is not available in sysroot. But nothing seems to have changed regarding Pango during the last days either.
>
> I am using `minimal` for `MACHINE = "beagleboard"`.
>
> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=9730a28e669931fee601756e949bb210999b4b81
>
> Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
> ---
>  recipes/gtk+/gtk+_2.20.1.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/gtk+/gtk+_2.20.1.bb b/recipes/gtk+/gtk+_2.20.1.bb
> index 6ef5e5b..915ccf5 100644
> --- a/recipes/gtk+/gtk+_2.20.1.bb
> +++ b/recipes/gtk+/gtk+_2.20.1.bb
> @@ -19,6 +19,8 @@ ARM_INSTRUCTION_SET = "arm"
>  DEPENDS_virtclass-native = "libpng-native atk-native pango-native cairo-native libxrender-native libxext-native libgcrypt-native"
>  PROVIDES_virtclass-native = "gdk-pixbuf-csource-native"
>
> +DEPENDS += "pango-native"
> +
>  # Enable xkb selectively
>  XKBTOGGLE = " --disable-xkb"
>  XKBTOGGLE_angstrom = ""
> --
>
I doubt that this is sound.
Your error indicates you are missing includes, so you might need a
DEPENDS on pango, not on pango-native (and maybe pango needs to be
fixed to put its stuff in the right dir or gtk+ to look at the right
place)
Then again I do not see any beagle specific include dirs in your path,
which also greatly surprises me.

And please also don't type things before the --- like "Dear OE folks.
Please do explanations below that line, so if your patch is accepted
people can just do a git am without the need to modify the commit
message.

One other thing:
*if* we need a depend on pango-native, I guess it should go from the
DEPENDS_virtclass-native. Then again I am not that good wrt the
machinery that I can say whether it will not add an additional -native
or so. I recall another issue with that from earlier this week. Then
again I feel the build machinery should not add an addtional -native
suffix to depends etc that already have -native at the end).

frans