[oe] [PATCH] prboom_2.5.0.bb: fix compilation failure due to undefined references.

[Frans Meulenbroeks]

2010/10/11 Graham Gower <graham.gower at gmail.com>:
> Need to #define _GNU_SOURCE for sched.h to define CPU_ZERO/CPU_SET.
>
>  SDL/libsdldoom.a(i_system.o): In function `I_SetAffinityMask':
> | i_system.c:(.text+0x7d4): undefined reference to `CPU_ZERO'
> | i_system.c:(.text+0x7e8): undefined reference to `CPU_SET'
> | collect2: ld returned 1 exit status
>
> Signed-off-by: Graham Gower <graham.gower at gmail.com>
> ---
>  .../prboom-2.5.0/gnu_source_for_sched_h.patch      |   12 ++++++++++++
>  recipes/prboom/prboom_2.5.0.bb                     |    3 ++-
>  2 files changed, 14 insertions(+), 1 deletions(-)
>  create mode 100644 recipes/prboom/prboom-2.5.0/gnu_source_for_sched_h.patch
>
> diff --git a/recipes/prboom/prboom-2.5.0/gnu_source_for_sched_h.patch b/recipes/prboom/prboom-2.5.0/gnu_source_for_sched_h.patch
> new file mode 100644
> index 0000000..e77917a
> --- /dev/null
> +++ b/recipes/prboom/prboom-2.5.0/gnu_source_for_sched_h.patch
> @@ -0,0 +1,12 @@
> +Upstream: http://sourceforge.net/mailarchive/forum.php?thread_name=4CB2549C.2030100%40gmail.com&forum_name=prboom-devel
> +
> +--- prboom-2.5.0/src/SDL/i_system.c.orig       2010-10-11 09:58:02.000000000 +1030
> ++++ prboom-2.5.0/src/SDL/i_system.c    2010-10-11 09:59:16.000000000 +1030
> +@@ -33,6 +33,7 @@
> +  *-----------------------------------------------------------------------------
> +  */
> +
> ++#define _GNU_SOURCE
> + #include <stdio.h>
> +
> + #include <stdarg.h>
> diff --git a/recipes/prboom/prboom_2.5.0.bb b/recipes/prboom/prboom_2.5.0.bb
> index 92a276d..13f3623 100644
> --- a/recipes/prboom/prboom_2.5.0.bb
> +++ b/recipes/prboom/prboom_2.5.0.bb
> @@ -4,10 +4,11 @@ PRIORITY = "optional"
>  DEPENDS = "virtual/libsdl libsdl-mixer libsdl-net"
>  LICENSE = "GPL"
>
> -PR = "r2"
> +PR = "r3"
>  RRECOMMENDS_${PN} = "freedoom"
>
>  SRC_URI = "${SOURCEFORGE_MIRROR}/prboom/prboom-${PV}.tar.gz \
> +          file://gnu_source_for_sched_h.patch \
>           "
>
>  inherit autotools
> --
> 1.7.1
>

Do you feel this is the preferred way?
I would probably not have made the patch but add -D_GNU_SOURCE to
CFLAGS. (I like to compile all the sources with the same flags to
avoid inconsistencies)

Frans

Frans