[oe] [PATCHv3 1/3] kernel bbclass: split do_compile into do_compile and do_compile_modules

[Frans Meulenbroeks]

2010/10/12 Koen Kooi <k.kooi at student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 12-10-10 12:08, Frans Meulenbroeks wrote:
>> 2010/10/12 Koen Kooi <k.kooi at student.utwente.nl>:
>
>>>> +}
>>>> +
>>>> +do_compile_kernelmodules() {
>>>> +     unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
>>
>> Is it needed/required?
>
> It is, and it's in kernel.bbclass already:
>
> fe938bbe (Michael Lauer 2004-12-14) kernel_do_compile() {
> 0448ec0d (Richard Purdie 2006-11-20)     unset CFLAGS CPPFLAGS CXXFLAGS
> LDFLAGS MACHINE
> fe938bbe (Michael Lauer 2004-12-14)     oe_runmake
> include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}"
>
>
>> I'm a little bit concerned by this.
>> (actually this was the only worry I had after reading the patch, don't
>> want to loose additional CFLAGS settings here
>
> You actually want to do that, since the kernel is bare-metal, not userspace.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFMtDm/MkyGM64RGpERAuFwAKCBzAXJwVvcQ6oh2DSISA/7Hhh8zACgp9M9
> muqzjUd8tGg/RCZoEKmsU/4=
> =1SOi
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Thanks for the answer.

Did a quick peek on CFLAGS in the recipes, saw there is a CFLAGS_KERNEL.
That one is only used on one place:
linux-wrt_2.4.30.bb:export CFLAGS_KERNEL="-fno-delayed-branch "

Haven't tested this, but my understanding on how things work is good
enough and the change simple enough for to give an ack
Acked-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>