[oe] apr-util_1.3.4.bb fails, looking at host includes

[J. L.]

On 10/13/10, Tasslehoff Kjappfot <tasskjapp at gmail.com> wrote:
>>
>> Am Mittwoch, den 13.10.2010, 14:39 +0200 schrieb Holger Freyther:
>>> On 10/13/2010 02:39 PM, Tasslehoff Kjappfot wrote:
>>>
>>>>
>>>> Signed-off-by: Tasslehoff Kjappfot <tasskjapp at gmail.com>
>>>> ---
>>>> recipes/apr/apr-util_1.3.4.bb |    1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/recipes/apr/apr-util_1.3.4.bb
>>>> b/recipes/apr/apr-util_1.3.4.bb
>>>> index cc6781b..5e31171 100644
>>>> --- a/recipes/apr/apr-util_1.3.4.bb
>>>> +++ b/recipes/apr/apr-util_1.3.4.bb
>>>> @@ -14,6 +14,7 @@ EXTRA_OECONF =
>>>> "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \
>>>>         --with-gdbm=${STAGING_DIR_HOST}${layout_prefix} \
>>>>         --without-sqlite2 \
>>>>         --without-sqlite3 \
>>>> +                --without-pgsql \
>>>
>>> hmm... the existing file is using spaces, you use tabs... I will fix it
>>> when
>>> pushing the changes. Please try to follow the indention of the file.
>>
>> Holger committed your patch in eba2dd [1]. It would be nice if you could
>> write a elaborate commit message next time with the actual error message
>> and reason added.
>>
>>  /checking for pg_config... /usr/bin/pg_config
>>     adding "-I/usr/include/postgresql" to CPPFLAGS
>>     adding "-L/usr/lib" to LDFLAGS/
>>
>> I build tested `r7` with `minimal-uclibc` for `MACHINE = "beagleboard"`
>> and it worked for me without any problems as it was with `r6`. But I did
>> not have `pg_config` installed on my build system anyway.
>>
>>
>> Thanks,
>>
>> Paul
>
> I did the patch with "git format-patch", but sent it with thunderbird. That
> caused the line-breaks and the spaces, I suspect. I'll setup git-send-email
> for future use and improve the commit messages. Thanks for cleaning up :)
>
> - Tasslehoff
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


Now seeing what you did I remembered that I had to install postgresql
on the build machine to get it to build.

Dumb question time, is this really a thing that needs patching? Reason
I ask is because now this is another package that will need to
modified in a user.collection to get postgresql support built in.
Shouldnt removing features be something the person building should do
in their user.collection folder or similar folder, and the packages in
the recipe folder should have the package allowing as many features as
possible in the configure? To me this doesnt seem like a fix just a
work around for his situation. This has been a question I have had for
a little while now and figured should ask while there is a subject
relating. Thanks for your time and letting me know about my questions
:)