[oe] [PATCH] [PATCH] distro: make TARGET_VENDOR a weak assignment to enable external-csl

[Ben Gardiner]

On Wed, Oct 13, 2010 at 3:09 PM, Denys Dmytriyenko <denis at denix.org> wrote:
> As I mentioned in the previous discussion, since inclusion of
> toolchain-external.inc happens before the inclusion of angstrom.inc, where
> TARGET_VENDOR is set unconditionally, it's not possible to control this
> variable from toolchain-external.inc...
>
> We either need to swap those two lines, so inclusion of toolchain-external.inc
> happens after the angstrom.inc is included (untested):
>
> diff --git a/conf/distro/angstrom-2008.1.conf
> b/conf/distro/angstrom-2008.1.conf
> index ec4f21e..1fd5ab6 100644
> --- a/conf/distro/angstrom-2008.1.conf
> +++ b/conf/distro/angstrom-2008.1.conf
> @@ -124,10 +124,6 @@ PREFERRED_VERSION_binutils_avr32 = "2.17"
>  PREFERRED_VERSION_binutils-cross_avr32 = "2.17"
>  PREFERRED_VERSION_binutils-cross-sdk_avr32 = "2.17"
>
> -# Toolchain virtuals:
> -require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}.inc
> -require conf/distro/include/arm-thumb.inc
> -
>  PREFERRED_PROVIDER_dbus-glib             = "dbus-glib"
>  PREFERRED_PROVIDER_hotplug               = "udev"
>  PREFERRED_PROVIDER_opkg                 ?= "opkg"
> @@ -143,6 +139,10 @@ ANGSTROMLIBC ?= "glibc"
>
>  require conf/distro/include/angstrom.inc
>
> +# Toolchain virtuals:
> +require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}.inc
> +require conf/distro/include/arm-thumb.inc
> +
>  # Set DISTRO_FEED_CONFIGS to our config var, assigned in the above .inc
>  DISTRO_FEED_CONFIGS = "${ANGSTROM_FEED_CONFIGS}"

I can confirm that this plus the toolchain-external changes proposed
yields the expected variables:

$bitbake -i
/usr/lib/pymodules/python2.6/bb/shell.py:59: DeprecationWarning: The
popen2 module is deprecated.  Use the subprocess module.
  import sys, os, readline, socket, httplib, urllib, commands, popen2,
copy, shlex, Queue, fnmatch
BitBake Shell Version 0.5.3.1 (C) 2005 Michael 'Mickey' Lauer
<mickey at Vanille.de>
Type 'help' for more information, press CTRL-D to exit.
BB>> parse
[snip]
NOTE: Handling BitBake files: | (7131/7131) [100 %]
NOTE: Parsing finished. 0 cached, 6796 parsed, 335 skipped, 2 masked.

BB>> getvar TOOLCHAIN_VENDOR
-none
BB>> getvar TARGET_VENDOR
-none
BB>> getvar TARGET_SYS
arm-none-linux-gnueabi

and that a build of angstrom-2008.1 doesn't yield errors about unfound
arm-angstrom-linux-gnueabi libraries.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca