[oe] [Bitbake-dev] [PATCH] fetchers: Use tar --exclude pattern to remove SCM files

[Martin Jansa]

On Sun, Oct 24, 2010 at 9:40 AM, Khem Raj <raj.khem at gmail.com> wrote:
> On Sat, Oct 23, 2010 at 11:58 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>> This commit is usefull for sure, but breaks ie some EFL recipes.
>>
>> ie python-elementary depends on elementary >= 0.7.0.52890
>> but elementary.pc says Version: 0.7.0.0
>>
>> elementary.pc.in says Version: @VERSION@
>>
>> and finally VERSION is defined in configure.ac:
>> m4_define([v_maj], [0])
>> m4_define([v_min], [7])
>> m4_define([v_mic], [0])
>> m4_define([v_rev], m4_esyscmd([(svnversion "${SVN_REPO_PATH:-.}" |
>> grep -v export || echo 0) | awk -F : '{printf("%s\n", $1);}' | tr -d '
>> :MSP\n']))
>> m4_if(v_rev, [0], [m4_define([v_rev], m4_esyscmd([git log 2> /dev/null
>> | (grep -m1 git-svn-id || echo 0) | sed -e 's/.*@\([0-9]*\).*/\1/' |
>> tr -d '\n']))])
>>
>
> hmm strange that a configure scripts depends on SCM files. To me it
> seems wrong. Anyway I think you can patch configure.ac
> to replace v_rev definition to be based on SRCREV may be some sort of
> sed operation as do_configure_prepend might be a good way

this is used in all efl recipes and I've noticed it in elementary only
because python-elementary depends on such new version.

I've also found similar construct in other projects.. so maybe it's
not so efl related (and then harder to found&fix in all recipes).

Regards,