[oe] [PATCH v2] epiphany-2.30.2: unbreak do_configure by setting ca-file path

[Khem Raj]

On 10/25/10, Steffen Sledz <sledz at dresearch.de> wrote:
> Am 25.10.2010 13:37, schrieb Paul Menzel:
>> Am Montag, den 25.10.2010, 11:55 +0200 schrieb Steffen Sledz:
>>> * Disable existence check for ca-bundle file in configure.ac because
>>>   it does not work in OE cross compile environment (location at build
>>>   host may differ from location at target).
>>> * Explicitely set ca-bundle file path according to the one used by
>>>   ca-certificates package.
>>> ...
>>> ++# disable this check because it does not work in all environments
>>> ++# (location at build host may differ from target)
>>> ++#    if ! test -f "$with_ca_file"; then
>>> ++#        AC_MSG_ERROR([No such file '$with_ca_file'. Use
>>> --with-ca-file=path to set, or --without-ca-file to disable])
>>> ++#    fi
>>
>> Would adding the following check also work?
>>
>>         if test "$cross_compiling" != "yes"; then
>>          …
>>         fi
>
> I don't think this is a good idea. It is not a problem of cross compiling.
> Cross compiling is just one case where it occurs.
>
> Also if i build for the same architecture it is not a good idea to check for
> the existence of a file *at buildtime* and compile this path into the
> binary.
>
> The existence of such a file should be checked and handled at runtime only.

For native build runtime and buildtimes are same even if you
are building in a chroot so its an ok assumption
adding a cross compile check is a good thing.

It works on debian derivatives because the paths match coincidently
so for target package it uses the ca files installed on build system
but for SuSE location is different so it fails.

You have my ack for the patch

Acked-by: Khem Raj <raj.khem at gmail.com>

>
>> I think this would be more portable. Could you report that issue
>> upstream too please.
>
> I'll try.
>
> Steffen
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


-- 
-Khem