[oe] [PATCH v2] bullet.bb New recipe

[Paul Menzel]

Am Dienstag, den 26.10.2010, 14:30 -0700 schrieb Khem Raj:
> On Tue, Oct 26, 2010 at 1:27 PM, David Batzle <dbatzle at dcbcyber.com> wrote:
> > ---
> >  recipes/bullet/bullet.bb |   14 ++++++++++++++
> >  1 files changed, 14 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes/bullet/bullet.bb
> >
> > diff --git a/recipes/bullet/bullet.bb b/recipes/bullet/bullet.bb
> > new file mode 100644
> > index 0000000..c466e7a
> > --- /dev/null
> > +++ b/recipes/bullet/bullet.bb
> > @@ -0,0 +1,14 @@
> > +DESCRIPTION = "Bullet Physics Library"
> > +HOMEPAGE = "www.bulletphysics.org"

All other recipes have »http« included in the URL.

	git grep "HOMEPAGE" recipes/

> > +LICENSE = "Zlib"
> 
> if you look closely under the sources different parts are licensed
> under different licenses
> while you are at it could you mention all the licenses that the
> package is using.
> 
> Otherwise it look ok.
> 
> > +PV = "2.77+svnr${SRCPV}"
> > +PR = "r0"
> 
> you could omit PR setting when its r0 i.e. initial first rev because
> bitbake will set it to r0
> if it does not find a PR definition but then if some fix it done later
> then it has to be bumped
> to r1 then one has to add that in recipe but its ok to set it to r0 as
> well its just FYI
> 
> > +
> > +SRC_URI = "svn://bullet.googlecode.com/svn;module=trunk;proto=http"
> > +
> > +SRCREV = "2218"
> > +S = "${WORKDIR}/trunk"
> > +
> > +inherit cmake
> > +
> > +EXTRA_OECMAKE = "-DBUILD_DEMOS:BOOL=OFF -DBUILD_EXTRAS:BOOL=OFF -DUSE_GLUT:BOOL=OFF -DBUILD_SHARED_LIBS:BOOL=ON"

Thank you for this patch iteration. I will test building your recipe as
soon as possible.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20101026/35a7ee84/attachment-0002.sig>