[oe] [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Khem Raj]

On Mon, Oct 25, 2010 at 11:36 PM, Frans Meulenbroeks
<fransmeulenbroeks at gmail.com> wrote:
> 2010/10/26 Graham Gower <graham.gower at gmail.com>:
>>
>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>
>> Signed-off-by: Graham Gower <graham.gower at gmail.com>
>> ---
>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>> index ba03f00..c2349e0 100644
>> --- a/recipes/espgs/espgs_8.15.3.bb
>> +++ b/recipes/espgs/espgs_8.15.3.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>  including bug fixes, new drivers, and additional support for CUPS."
>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>  SECTION = "libs"
>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>  LICENSE = "GPL"
>>  PR = "r1"
>>
>>
>
> Three small remarks:
> - not sure if changes like this require a PR bump. I always choose the
> the safe way and bump when in doubt.

Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.

> - it would be nice if, when you are fixing a recipe you would also
> improve the LICENSE = "GPL" thing

yes.

> - and there is also a 7.07.1 recipe. Should this apply to this version
> as well (or alternately should we remove that recipe?)
>

probably remove the old recipe.

> Acked-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>