[oe] [PATCH] sip-native: Run oe-stylize script on the recipe and modify the recipe accordingly.
Michael 'Mickey' Lauer
mickey at vanille-media.de
Wed Sep 1 23:00:09 UTC 2010
Thanks for your patch, but here's what I don't like
(yes, probably oe-stylize is to blame, perhaps someone
could fix it there)
> -export BUILD_SYS
> -export HOST_SYS
> -export STAGING_LIBDIR
> -export STAGING_INCDIR
> -
> EXTRA_QMAKEVARS_POST += "DESTDIR=${S} CONFIG=console"
>
> do_configure_prepend() {
> - cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> + cat sipgen.sbf | sed s,target,TARGET, | sed s,sources,SOURCES, | sed s,headers,HEADERS, > sipgen.pro
> }
> -
> do_stage() {
> - install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> - cd ${WORKDIR}/sip-${PV} && python configure.py
> - install -d ${STAGING_PYDIR}/site-packages
> - install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip ${STAGING_BINDIR_NATIVE}/sip
> + cd ${WORKDIR}/sip-${PV} && python configure.py
> + install -d ${STAGING_PYDIR}/site-packages
> + install -m 0755 sip*.py ${STAGING_PYDIR}/site-packages
> }
>
> -SRC_URI[md5sum] = "597d7ff7edb42a18421c806ffd18a136"
> -SRC_URI[sha256sum] = "7faaccb6f17296399051bd076a7f41e0f6d95a28eda3e30468f1bd7cf45898e1"
> +export BUILD_SYS
> +export HOST_SYS
> +export STAGING_LIBDIR
> +export STAGING_INCDIR
> +
> +DEFAULT_PREFERENCE = "-1"
I like to keep a mental model of recipes being somewhat executed in a
top-down manner; in the model, exported variable assignments do in fact
affect all of tasks, so I think they should be kept next to the
non-exported assignments.
--
:M:
More information about the Openembedded-devel
mailing list