[oe] [PATCH] rename SOC_FAMILY to TARGET_SOC_FAMILY and make it global

Maupin, Chase chase.maupin at ti.com
Tue Sep 7 14:43:44 UTC 2010


> add global OVERRIDES ${TARGET_SOC_FAMILY} and
> ${TARGET_ARCH}_${TARGET_SOC_FAMILY}
> 
For my part I would ask why you are renaming SOC_FAMILY to TARGET_SOC_FAMILY?  Why not leave the name the way it is since others may be using it in overlays, etc?

Also, you might want to make sure your patch would include Fran's fix to base.bbclass that he mentioned at http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-September/023680.html

For what my input is worth I would NAK this patch because:

1.  I don't see a reason to add this to the generic set of overrides.
2.  I don't understand why the name of the variable SOC_FAMILY needs to be changed.  I know this will break existing overlays and I don't see any reason why the change is made.
3.  I disagree with the ${TARGET_ARCH}_${TARGET_SOC_FAMILY} override.  If you have two patch series for different architectures then you should have two SOC_FAMILY settings or use the MACHINE setting for the override.  I think this override is confusing and redundant.




More information about the Openembedded-devel mailing list