[oe] [PATCH] rename SOC_FAMILY to TARGET_SOC_FAMILY and make it global
Phil Blundell
philb at gnu.org
Thu Sep 9 09:26:39 UTC 2010
On Sat, 2010-09-04 at 05:14 +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> diff --git a/conf/bitbake.conf b/conf/bitbake.conf
> index 677c76a..672d8df 100644
> --- a/conf/bitbake.conf
> +++ b/conf/bitbake.conf
> @@ -113,6 +113,8 @@ TARGET_SYS = "${TARGET_ARCH}${TARGET_VENDOR}${@['-' + bb.data.getVar('TARGET_OS'
> TARGET_PREFIX = "${TARGET_SYS}-"
> TARGET_CC_ARCH = ""
> TARGET_EXEEXT = ""
> +TARGET_SOC_FAMILY ?= "Unknown"
> +
>
> SDK_ARCH ?= "${BUILD_ARCH}"
> SDK_OS ?= "${BUILD_OS}"
> @@ -677,9 +679,9 @@ BUILDCFG_NEEDEDVARS ?= "TARGET_ARCH TARGET_OS"
> #
> # This works for functions as well, they are really just environment variables.
> # Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
> -OVERRIDES = "local:${MACHINE}:${DISTRO}:${TARGET_OS}:${TARGET_ARCH}:build-${BUILD_OS}:fail-fast:pn-${PN}"
> +OVERRIDES = "local:${MACHINE}:${DISTRO}:${TARGET_OS}:${TARGET_ARCH}:${TARGET_SOC_FAMILY}:${TARGET_ARCH}_${TARGET_SOC_FAMILY}:build-${BUILD_OS}:fail-fast:pn-${PN}"
I don't have much of an opinion on the renaming, but the overrides part
will cause an unacceptable level of namespace pollution. As it stands,
everybody will suddenly get "Unknown" in their OVERRIDES and this is not
at all desirable.
If you must add these kinds of things to the default OVERRIDES then they
need a suitable namespace prefix, for example something like
soc-family-${SOC_FAMILY}. (Alternatively, put it in your own DISTRO
configuration where you can do whatever you like.)
p.
More information about the Openembedded-devel
mailing list