[oe] [PATCH] glib-1.2: merged native and non-native recipes

[Vitus Jensen]

Hello Fahad,

On Wed, 8 Sep 2010, Fahad Usman wrote:

> * removed the glib-1.2-native_1.2.10.bb file
> * added NATIVE_INSTALL_WORKS = "1"
> * added BBCLASSEXTEND = "native"
> * converted do_stage of native recipe to do_install_virtclass-native in the combined recipe
> * added DEPENDS_virtclass-native = "" to avoid dependencies loops
> * added gettext in inherit because it was needed by the native recipes
> * bumped PR
>
> Signed-off-by: Fahad Usman <fahad_usman at mentor.com>
> ---
> recipes/glib-1.2/glib-1.2-native_1.2.10.bb |   49 ----------------------------
> recipes/glib-1.2/glib-1.2_1.2.10.bb        |   20 ++++++++++-
> 2 files changed, 18 insertions(+), 51 deletions(-)


> diff --git a/recipes/glib-1.2/glib-1.2_1.2.10.bb b/recipes/glib-1.2/glib-1.2_1.2.10.bb
> index 72ee826..67266d4 100644
> --- a/recipes/glib-1.2/glib-1.2_1.2.10.bb
> +++ b/recipes/glib-1.2/glib-1.2_1.2.10.bb
> @@ -4,7 +4,8 @@ SECTION = "libs"
> PRIORITY = "optional"
> LICENSE = "LGPL"
> DEPENDS = "glib-1.2-native"
> -PR = "r4"
> +DEPENDS_virtclass-native = ""
> +PR = "r5"

I don't know if everyone thinks so but I feel the following line is more 
elegant:

DEPENDS_pn-glib-1.2 += "glib-1.2-native"

You skip the DEPENDS_virtclass-native line and may use the "+=" operator.

Best regards,
    Vitus

PS: taken from my htmldoc recipe in patchwork

-- 
Vitus Jensen, Hannover, Germany, Universe (current)
pgp public key available from keyservers